perf: apply record optimistic effects with cache.modify on mutation (#3540)

* perf: apply record optimistic effects with cache.modify on mutation

Closes #3509

* refactor: return early when created records do not match filter

* fix: fix id generation on record creation

* fix: comment filtering behavior on record creation

* Fixed typing error

* refactor: review - use ??

* refactor: review - add variables in readFieldValueToSort

* docs: review - add comments for variables.first in triggerUpdateRecordOptimisticEffect

* refactor: review - add intermediary variable for 'not' filter in useMultiObjectSearchMatchesSearchFilterAndToSelectQuery

* refactor: review - add filter utils

* fix: fix tests

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>

packages/twenty-front/src/modules/object-record/utils/andFilterVariables.ts

@@ -0,0 +1,14 @@
+import { ObjectRecordQueryFilter } from '@/object-record/record-filter/types/ObjectRecordQueryFilter';
+import { isDefined } from '~/utils/isDefined';
+
+export const andFilterVariables = (
+  filters: (ObjectRecordQueryFilter | undefined)[],
+): ObjectRecordQueryFilter | undefined => {
+  const definedFilters = filters.filter(isDefined);
+
+  if (!definedFilters.length) return undefined;
+
+  return definedFilters.length === 1
+    ? definedFilters[0]
+    : { and: definedFilters };
+};

packages/twenty-front/src/modules/object-record/utils/generateDeleteOneRecordMutation.ts

@@ -4,6 +4,10 @@ import { EMPTY_MUTATION } from '@/object-metadata/hooks/useObjectMetadataItem';
 import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
 import { capitalize } from '~/utils/string/capitalize';
 
+export const getDeleteOneRecordMutationResponseField = (
+  objectNameSingular: string,
+) => `delete${capitalize(objectNameSingular)}`;
+
 export const generateDeleteOneRecordMutation = ({
   objectMetadataItem,
 }: {
@@ -15,9 +19,13 @@ export const generateDeleteOneRecordMutation = ({
 
   const capitalizedObjectName = capitalize(objectMetadataItem.nameSingular);
 
+  const mutationResponseField = getDeleteOneRecordMutationResponseField(
+    objectMetadataItem.nameSingular,
+  );
+
   return gql`
     mutation DeleteOne${capitalizedObjectName}($idToDelete: ID!)  {
-      delete${capitalizedObjectName}(id: $idToDelete) {
+      ${mutationResponseField}(id: $idToDelete) {
         id
       }
     }

packages/twenty-front/src/modules/object-record/utils/orFilterVariables.ts

@@ -0,0 +1,14 @@
+import { ObjectRecordQueryFilter } from '@/object-record/record-filter/types/ObjectRecordQueryFilter';
+import { isDefined } from '~/utils/isDefined';
+
+export const orFilterVariables = (
+  filters: (ObjectRecordQueryFilter | undefined)[],
+): ObjectRecordQueryFilter | undefined => {
+  const definedFilters = filters.filter(isDefined);
+
+  if (!definedFilters.length) return undefined;
+
+  return definedFilters.length === 1
+    ? definedFilters[0]
+    : { or: definedFilters };
+};