better logging in order to investigate later one on this kind of error (#12326)
# extracting domain emails Added new test cases covering weird but valid email formats (plus addressing, subdomains, international domains, etc.) to identify potential failures in the current implementation. Two tests with quoted local parts containing @ symbols or quotes are marked as skipped since they're expected to fail with the current simple string splitting approach. They are too exotic IMO, we should throw errors. ## Next We will monitor errors related to this and update accordingly later on. ### Note technically, quotes are possible in RFC see [here](https://stackoverflow.com/questions/4816424/are-single-quotes-legal-in-the-name-part-of-an-email-address) --------- Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
@ -48,6 +48,7 @@ export const RecordChip = ({
|
||||
const recordIndexOpenRecordIn = useRecoilValue(recordIndexOpenRecordInState);
|
||||
|
||||
// TODO temporary until we create a record show page for Workspaces members
|
||||
|
||||
if (
|
||||
forceDisableClick ||
|
||||
objectNameSingular === CoreObjectNameSingular.WorkspaceMember
|
||||
@ -61,7 +62,7 @@ export const RecordChip = ({
|
||||
avatarType={recordChipData.avatarType}
|
||||
avatarUrl={recordChipData.avatarUrl ?? ''}
|
||||
className={className}
|
||||
variant={ChipVariant.Static}
|
||||
variant={ChipVariant.Transparent}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
@ -12,6 +12,7 @@ export const ActorFieldDisplay = () => {
|
||||
}
|
||||
|
||||
const { fieldValue, name, avatarUrl } = actorFieldDisplay;
|
||||
|
||||
return displayActorField ? (
|
||||
<ActorDisplay
|
||||
name={name}
|
||||
|
||||
Reference in New Issue
Block a user