Use new type position for standard objects and newly created objects (#4349)

Co-authored-by: Thomas Trompette <thomast@twenty.com>

packages/twenty-front/src/modules/object-metadata/hooks/useMapFieldMetadataToGraphQLQuery.ts

@@ -29,6 +29,7 @@ export const useMapFieldMetadataToGraphQLQuery = () => {
         'BOOLEAN',
         'RATING',
         'SELECT',
+        'POSITION',
       ] as FieldType[]
     ).includes(fieldType);
 

packages/twenty-server/src/core/api-rest/api-rest-query-builder/utils/map-field-metadata-to-graphql-query.utils.ts

@@ -22,6 +22,7 @@ export const mapFieldMetadataToGraphqlQuery = (
     FieldMetadataType.EMAIL,
     FieldMetadataType.NUMBER,
     FieldMetadataType.BOOLEAN,
+    FieldMetadataType.POSITION,
   ].includes(fieldType);
 
   if (fieldIsSimpleValue) {

packages/twenty-server/src/core/open-api/utils/components.utils.ts

@@ -36,6 +36,7 @@ const getSchemaComponentsProperties = (
       case FieldMetadataType.NUMERIC:
       case FieldMetadataType.PROBABILITY:
       case FieldMetadataType.RATING:
+      case FieldMetadataType.POSITION:
         itemProperty.type = 'number';
         break;
       case FieldMetadataType.BOOLEAN:

packages/twenty-server/src/metadata/object-metadata/object-metadata.service.ts

@@ -291,7 +291,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
             defaultValue: { type: 'now' },
           },
           {
-            type: FieldMetadataType.NUMBER,
+            type: FieldMetadataType.POSITION,
             name: 'position',
             label: 'Position',
             targetColumnMap: {

packages/twenty-server/src/metadata/workspace-migration/factories/basic-column-action.factory.ts

@@ -24,7 +24,8 @@ export type BasicFieldMetadataType =
   | FieldMetadataType.PROBABILITY
   | FieldMetadataType.BOOLEAN
   | FieldMetadataType.POSITION
-  | FieldMetadataType.DATE_TIME;
+  | FieldMetadataType.DATE_TIME
+  | FieldMetadataType.POSITION;
 
 @Injectable()
 export class BasicColumnActionFactory extends ColumnActionAbstractFactory<BasicFieldMetadataType> {

packages/twenty-server/src/workspace/workspace-schema-builder/graphql-types/scalars/position.scalar.ts

@@ -12,6 +12,7 @@ const checkPosition = (value: any): PositionType => {
   if (isValidNumberPosition(value) || isValidStringPosition(value)) {
     return value;
   }
+
   throw new Error('Invalid position found');
 };
 

packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/company.object-metadata.ts

@@ -99,9 +99,9 @@ export class CompanyObjectMetadata extends BaseObjectMetadata {
   idealCustomerProfile: boolean;
 
   @FieldMetadata({
-    type: FieldMetadataType.NUMBER,
+    type: FieldMetadataType.POSITION,
     label: 'Position',
-    description: 'Position',
+    description: 'Company record position',
     icon: 'IconHierarchy2',
   })
   @IsSystem()

packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/opportunity.object-metadata.ts

@@ -82,9 +82,9 @@ export class OpportunityObjectMetadata extends BaseObjectMetadata {
   stage: string;
 
   @FieldMetadata({
-    type: FieldMetadataType.NUMBER,
+    type: FieldMetadataType.POSITION,
     label: 'Position',
-    description: 'Position',
+    description: 'Opportunity record position',
     icon: 'IconHierarchy2',
   })
   @IsSystem()

packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/person.object-metadata.ts

@@ -97,9 +97,9 @@ export class PersonObjectMetadata extends BaseObjectMetadata {
   avatarUrl: string;
 
   @FieldMetadata({
-    type: FieldMetadataType.NUMBER,
+    type: FieldMetadataType.POSITION,
     label: 'Position',
-    description: 'Record Position',
+    description: 'Person record Position',
     icon: 'IconHierarchy2',
   })
   @IsSystem()