admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed single record picker missing dropdown separator (#12672)

Browse Source 
This PR fixes a missing dropdown menu separator when no result found in
a single record picker.

Before : 


![image](https://github.com/user-attachments/assets/77ea2275-cace-443b-b691-bab52dd8cfc0)

After : 

<img width="233" alt="image"
src="https://github.com/user-attachments/assets/73919d63-3126-4b56-b335-34d3c9d6ac15"
/>

Fixes https://github.com/twentyhq/twenty/issues/12665
This commit is contained in:
Lucas Bordeau
2025-06-17 14:30:17 +02:00
committed by GitHub
parent efe1700cc8
commit 01a69f6288
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/twenty-front/src/modules/object-record/record-picker/single-record-picker/components/SingleRecordPickerMenuItemsWithSearch.tsx
View File

@ -82,11 +82,13 @@ export const SingleRecordPickerMenuItemsWithSearch = ({
{layoutDirection === 'search-bar-on-bottom' && ( {layoutDirection === 'search-bar-on-bottom' && (
<> <>
{isDefined(onCreate) && hasObjectUpdatePermissions && ( {isDefined(onCreate) && hasObjectUpdatePermissions && (
<DropdownMenuItemsContainer scrollable={false}> <>
{createNewButton} <DropdownMenuItemsContainer scrollable={false}>
</DropdownMenuItemsContainer> {createNewButton}
</DropdownMenuItemsContainer>
<DropdownMenuSeparator />
</>
)} )}
{records.recordsToSelect.length > 0 && <DropdownMenuSeparator />}
<SingleRecordPickerMenuItems <SingleRecordPickerMenuItems
recordsToSelect={records.recordsToSelect} recordsToSelect={records.recordsToSelect}
loading={records.loading} loading={records.loading}
@ -122,13 +124,13 @@ export const SingleRecordPickerMenuItemsWithSearch = ({
onRecordSelected, onRecordSelected,
}} }}
/> />
{records.recordsToSelect.length > 0 && isDefined(onCreate) && (
<DropdownMenuSeparator />
)}
{isDefined(onCreate) && hasObjectUpdatePermissions && ( {isDefined(onCreate) && hasObjectUpdatePermissions && (
<DropdownMenuItemsContainer scrollable={false}> <>
{createNewButton} <DropdownMenuSeparator />
</DropdownMenuItemsContainer> <DropdownMenuItemsContainer scrollable={false}>
{createNewButton}
</DropdownMenuItemsContainer>
</>
)} )}
</> </>
)} )}