admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Improve gmail error handling by catching and throttling for 400 failedPrecondition (#6044)

Browse Source 
Closes #5897
This commit is contained in:
bosiraphael
2024-06-27 09:57:19 +02:00
committed by GitHub
parent 08c081d315
commit 03b00c49d5
1 changed files with 100 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

136
packages/twenty-server/src/modules/messaging/common/services/messaging-error-handling.service.ts
View File

@ -51,6 +51,21 @@ export class MessagingErrorHandlingService {
workspaceId, workspaceId,
); );
} }
if (reason === 'failedPrecondition') {
await this.handleFailedPrecondition(
error,
syncStep,
messageChannel,
workspaceId,
);
} else {
await this.handleUnknownError(
error,
syncStep,
messageChannel,
workspaceId,
);
}
break; break;
case 404: case 404:
await this.handleNotFound(error, syncStep, messageChannel, workspaceId); await this.handleNotFound(error, syncStep, messageChannel, workspaceId);
@ -152,44 +167,24 @@ export class MessagingErrorHandlingService {
message: `${error.code}: ${error.reason}`, message: `${error.code}: ${error.reason}`,
}); });
if ( await this.handleThrottle(syncStep, messageChannel, workspaceId);
messageChannel.throttleFailureCount >= MESSAGING_THROTTLE_MAX_ATTEMPTS }
) {
await this.messagingChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport(
messageChannel.id,
workspaceId,
);
return; private async handleFailedPrecondition(
} error: GmailError,
syncStep: SyncStep,
messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
workspaceId: string,
): Promise<void> {
await this.messagingTelemetryService.track({
eventName: `${snakeCase(syncStep)}.error.failed_precondition`,
workspaceId,
connectedAccountId: messageChannel.connectedAccountId,
messageChannelId: messageChannel.id,
message: `${error.code}: ${error.reason}`,
});
await this.throttle(messageChannel, workspaceId); await this.handleThrottle(syncStep, messageChannel, workspaceId);
switch (syncStep) {
case 'full-message-list-fetch':
await this.messagingChannelSyncStatusService.scheduleFullMessageListFetch(
messageChannel.id,
workspaceId,
);
break;
case 'partial-message-list-fetch':
await this.messagingChannelSyncStatusService.schedulePartialMessageListFetch(
messageChannel.id,
workspaceId,
);
break;
case 'messages-import':
await this.messagingChannelSyncStatusService.scheduleMessagesImport(
messageChannel.id,
workspaceId,
);
break;
default:
break;
}
} }
private async handleInsufficientPermissions( private async handleInsufficientPermissions(
@ -247,6 +242,51 @@ export class MessagingErrorHandlingService {
); );
} }
private async handleThrottle(
syncStep: SyncStep,
messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
workspaceId: string,
): Promise<void> {
if (
messageChannel.throttleFailureCount >= MESSAGING_THROTTLE_MAX_ATTEMPTS
) {
await this.messagingChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport(
messageChannel.id,
workspaceId,
);
return;
}
await this.throttle(messageChannel, workspaceId);
switch (syncStep) {
case 'full-message-list-fetch':
await this.messagingChannelSyncStatusService.scheduleFullMessageListFetch(
messageChannel.id,
workspaceId,
);
break;
case 'partial-message-list-fetch':
await this.messagingChannelSyncStatusService.schedulePartialMessageListFetch(
messageChannel.id,
workspaceId,
);
break;
case 'messages-import':
await this.messagingChannelSyncStatusService.scheduleMessagesImport(
messageChannel.id,
workspaceId,
);
break;
default:
break;
}
}
private async throttle( private async throttle(
messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>, messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
workspaceId: string, workspaceId: string,
@ -264,4 +304,28 @@ export class MessagingErrorHandlingService {
message: `Increment throttle failure count to ${messageChannel.throttleFailureCount}`, message: `Increment throttle failure count to ${messageChannel.throttleFailureCount}`,
}); });
} }
private async handleUnknownError(
error: GmailError,
syncStep: SyncStep,
messageChannel: ObjectRecord<MessageChannelWorkspaceEntity>,
workspaceId: string,
): Promise<void> {
await this.messagingTelemetryService.track({
eventName: `${snakeCase(syncStep)}.error.unknown`,
workspaceId,
connectedAccountId: messageChannel.connectedAccountId,
messageChannelId: messageChannel.id,
message: `${error.code}: ${error.reason}`,
});
await this.messagingChannelSyncStatusService.markAsFailedUnknownAndFlushMessagesToImport(
messageChannel.id,
workspaceId,
);
throw new Error(
`Unhandled Gmail error code ${error.code} with reason ${error.reason}`,
);
}
} }