Refactored all FieldDisplay types for performance optimization (#5768)
This PR is the second part of https://github.com/twentyhq/twenty/pull/5693. It optimizes all remaining field types. The observed improvements are : - x2 loading time improvement on table rows - more consistent render time Here's a summary of measured improvements, what's given here is the average of hundreds of renders with a React Profiler component. (in our Storybook performance stories) | Component | Before (µs) | After (µs) | | ----- | ------------- | --- | | TextFieldDisplay | 127 | 83 | | EmailFieldDisplay | 117 | 83 | | NumberFieldDisplay | 97 | 56 | | DateFieldDisplay | 240 | 52 | | CurrencyFieldDisplay | 236 | 110 | | FullNameFieldDisplay | 131 | 85 | | AddressFieldDisplay | 118 | 81 | | BooleanFieldDisplay | 130 | 100 | | JSONFieldDisplay | 248 | 49 | | LinksFieldDisplay | 1180 | 140 | | LinkFieldDisplay | 140 | 78 | | MultiSelectFieldDisplay | 770 | 130 | | SelectFieldDisplay | 230 | 87 |
This commit is contained in:
@ -3,10 +3,12 @@ import {
|
||||
mockedObjectMetadataItems,
|
||||
mockedPersonObjectMetadataItem,
|
||||
} from '~/testing/mock-data/metadata';
|
||||
import { mockedPeopleData } from '~/testing/mock-data/people';
|
||||
import { getPeopleMock } from '~/testing/mock-data/people';
|
||||
|
||||
import { getRecordNodeFromRecord } from '../getRecordNodeFromRecord';
|
||||
|
||||
const peopleMock = getPeopleMock();
|
||||
|
||||
describe('getRecordNodeFromRecord', () => {
|
||||
it('computes relation records cache references by default', () => {
|
||||
// Given
|
||||
@ -19,7 +21,7 @@ describe('getRecordNodeFromRecord', () => {
|
||||
name: true,
|
||||
company: true,
|
||||
};
|
||||
const record = mockedPeopleData[0];
|
||||
const record = peopleMock[0];
|
||||
|
||||
// When
|
||||
const result = getRecordNodeFromRecord({
|
||||
@ -33,12 +35,12 @@ describe('getRecordNodeFromRecord', () => {
|
||||
expect(result).toEqual({
|
||||
__typename: 'Person',
|
||||
company: {
|
||||
__ref: 'Company:5c21e19e-e049-4393-8c09-3e3f8fb09ecb',
|
||||
__ref: `Company:${record.company.id}`,
|
||||
},
|
||||
name: {
|
||||
__typename: 'FullName',
|
||||
firstName: 'Alexandre',
|
||||
lastName: 'Prot',
|
||||
firstName: record.name.firstName,
|
||||
lastName: record.name.lastName,
|
||||
},
|
||||
});
|
||||
});
|
||||
@ -54,7 +56,7 @@ describe('getRecordNodeFromRecord', () => {
|
||||
name: true,
|
||||
company: true,
|
||||
};
|
||||
const record = mockedPeopleData[0];
|
||||
const record = peopleMock[0];
|
||||
const computeReferences = false;
|
||||
|
||||
// When
|
||||
@ -72,8 +74,8 @@ describe('getRecordNodeFromRecord', () => {
|
||||
company: record.company,
|
||||
name: {
|
||||
__typename: 'FullName',
|
||||
firstName: 'Alexandre',
|
||||
lastName: 'Prot',
|
||||
firstName: record.name.firstName,
|
||||
lastName: record.name.lastName,
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user