Refactored all FieldDisplay types for performance optimization (#5768)

This PR is the second part of
https://github.com/twentyhq/twenty/pull/5693.

It optimizes all remaining field types.

The observed improvements are :
- x2 loading time improvement on table rows
- more consistent render time

Here's a summary of measured improvements, what's given here is the
average of hundreds of renders with a React Profiler component. (in our
Storybook performance stories)

| Component | Before (µs) | After (µs) |
| ----- | ------------- | --- |
| TextFieldDisplay | 127 | 83 |
| EmailFieldDisplay | 117 | 83 |
| NumberFieldDisplay | 97 | 56 |
| DateFieldDisplay | 240 | 52 |
| CurrencyFieldDisplay | 236 | 110 |
| FullNameFieldDisplay | 131 | 85 |
| AddressFieldDisplay | 118 | 81 |
| BooleanFieldDisplay | 130 | 100 |
| JSONFieldDisplay | 248 | 49 |
| LinksFieldDisplay | 1180 | 140 |
| LinkFieldDisplay | 140 | 78 |
| MultiSelectFieldDisplay | 770 | 130 |
| SelectFieldDisplay | 230 | 87 |

packages/twenty-front/src/modules/ui/field/display/components/EmailDisplay.tsx

@@ -1,21 +1,39 @@
 import { MouseEvent } from 'react';
 
 import { ContactLink } from '@/ui/navigation/link/components/ContactLink';
+import { isDefined } from '~/utils/isDefined';
 
 import { EllipsisDisplay } from './EllipsisDisplay';
 
 const validateEmail = (email: string) => {
-  const emailPattern = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
-  return emailPattern.test(email.trim());
+  // const emailPattern = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
+  // return emailPattern.test(email.trim());
+
+  // Record this without using regex
+  const emailParts = email.split('@');
+
+  if (emailParts.length !== 2) {
+    return false;
+  }
+
+  return true;
 };
 
 type EmailDisplayProps = {
   value: string | null;
 };
 
-export const EmailDisplay = ({ value }: EmailDisplayProps) => (
-  <EllipsisDisplay>
-    {value && validateEmail(value) ? (
+export const EmailDisplay = ({ value }: EmailDisplayProps) => {
+  if (!isDefined(value)) {
+    return <ContactLink href="#">{value}</ContactLink>;
+  }
+
+  if (!validateEmail(value)) {
+    return <ContactLink href="#">{value}</ContactLink>;
+  }
+
+  return (
+    <EllipsisDisplay>
       <ContactLink
         href={`mailto:${value}`}
         onClick={(event: MouseEvent<HTMLElement>) => {
@@ -24,8 +42,6 @@ export const EmailDisplay = ({ value }: EmailDisplayProps) => (
       >
         {value}
       </ContactLink>
-    ) : (
-      <ContactLink href="#">{value}</ContactLink>
-    )}
-  </EllipsisDisplay>
-);
+    </EllipsisDisplay>
+  );
+};