Refactored all FieldDisplay types for performance optimization (#5768)
This PR is the second part of https://github.com/twentyhq/twenty/pull/5693. It optimizes all remaining field types. The observed improvements are : - x2 loading time improvement on table rows - more consistent render time Here's a summary of measured improvements, what's given here is the average of hundreds of renders with a React Profiler component. (in our Storybook performance stories) | Component | Before (µs) | After (µs) | | ----- | ------------- | --- | | TextFieldDisplay | 127 | 83 | | EmailFieldDisplay | 117 | 83 | | NumberFieldDisplay | 97 | 56 | | DateFieldDisplay | 240 | 52 | | CurrencyFieldDisplay | 236 | 110 | | FullNameFieldDisplay | 131 | 85 | | AddressFieldDisplay | 118 | 81 | | BooleanFieldDisplay | 130 | 100 | | JSONFieldDisplay | 248 | 49 | | LinksFieldDisplay | 1180 | 140 | | LinkFieldDisplay | 140 | 78 | | MultiSelectFieldDisplay | 770 | 130 | | SelectFieldDisplay | 230 | 87 |
This commit is contained in:
@ -2,7 +2,6 @@ import { useEffect } from 'react';
|
||||
import { Decorator } from '@storybook/react';
|
||||
import { useRecoilCallback } from 'recoil';
|
||||
|
||||
import { Company } from '@/companies/types/Company';
|
||||
import { formatFieldMetadataItemAsColumnDefinition } from '@/object-metadata/utils/formatFieldMetadataItemAsColumnDefinition';
|
||||
import { isLabelIdentifierField } from '@/object-metadata/utils/isLabelIdentifierField';
|
||||
import { FieldContext } from '@/object-record/record-field/contexts/FieldContext';
|
||||
@ -12,18 +11,17 @@ import {
|
||||
} from '@/object-record/record-store/contexts/RecordFieldValueSelectorContext';
|
||||
import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
|
||||
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
|
||||
import { Person } from '@/people/types/Person';
|
||||
import { mockedCompaniesDataV2 } from '~/testing/mock-data/companiesV2';
|
||||
import { getCompaniesMock } from '~/testing/mock-data/companies';
|
||||
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/objectMetadataItems';
|
||||
import { mockPeopleDataV2 } from '~/testing/mock-data/peopleV2';
|
||||
import { getPeopleMock } from '~/testing/mock-data/people';
|
||||
import { isDefined } from '~/utils/isDefined';
|
||||
|
||||
const RecordMockSetterEffect = ({
|
||||
companies,
|
||||
people,
|
||||
}: {
|
||||
companies: Company[];
|
||||
people: Person[];
|
||||
companies: ObjectRecord[];
|
||||
people: ObjectRecord[];
|
||||
}) => {
|
||||
const setRecordValue = useSetRecordValue();
|
||||
|
||||
@ -56,21 +54,25 @@ export const getFieldDecorator =
|
||||
fieldValue?: any,
|
||||
): Decorator =>
|
||||
(Story) => {
|
||||
const companiesMock = getCompaniesMock();
|
||||
|
||||
const companies =
|
||||
objectNameSingular === 'company' && isDefined(fieldValue)
|
||||
? [
|
||||
{ ...mockedCompaniesDataV2[0], [fieldName]: fieldValue },
|
||||
...mockedCompaniesDataV2.slice(1),
|
||||
{ ...companiesMock[0], [fieldName]: fieldValue },
|
||||
...companiesMock.slice(1),
|
||||
]
|
||||
: mockedCompaniesDataV2;
|
||||
: companiesMock;
|
||||
|
||||
const peopleMock = getPeopleMock();
|
||||
|
||||
const people =
|
||||
objectNameSingular === 'person' && isDefined(fieldValue)
|
||||
? [
|
||||
{ ...mockPeopleDataV2[0], [fieldName]: fieldValue },
|
||||
...mockPeopleDataV2.slice(1),
|
||||
{ ...peopleMock[0], [fieldName]: fieldValue },
|
||||
...peopleMock.slice(1),
|
||||
]
|
||||
: mockPeopleDataV2;
|
||||
: peopleMock;
|
||||
|
||||
const record = objectNameSingular === 'company' ? companies[0] : people[0];
|
||||
|
||||
|
||||
Reference in New Issue
Block a user