Refactored all FieldDisplay types for performance optimization (#5768)
This PR is the second part of https://github.com/twentyhq/twenty/pull/5693. It optimizes all remaining field types. The observed improvements are : - x2 loading time improvement on table rows - more consistent render time Here's a summary of measured improvements, what's given here is the average of hundreds of renders with a React Profiler component. (in our Storybook performance stories) | Component | Before (µs) | After (µs) | | ----- | ------------- | --- | | TextFieldDisplay | 127 | 83 | | EmailFieldDisplay | 117 | 83 | | NumberFieldDisplay | 97 | 56 | | DateFieldDisplay | 240 | 52 | | CurrencyFieldDisplay | 236 | 110 | | FullNameFieldDisplay | 131 | 85 | | AddressFieldDisplay | 118 | 81 | | BooleanFieldDisplay | 130 | 100 | | JSONFieldDisplay | 248 | 49 | | LinksFieldDisplay | 1180 | 140 | | LinkFieldDisplay | 140 | 78 | | MultiSelectFieldDisplay | 770 | 130 | | SelectFieldDisplay | 230 | 87 |
This commit is contained in:
@ -49,8 +49,21 @@ export default defineConfig(({ command, mode }) => {
|
||||
}),
|
||||
svgr(),
|
||||
checker(checkers),
|
||||
// TODO: fix this, we have to restrict the include to only the components that are using linaria
|
||||
// Otherwise the build will fail because wyw tries to include emotion styled components
|
||||
wyw({
|
||||
include: ['**/EllipsisDisplay.tsx', '**/ContactLink.tsx'],
|
||||
include: [
|
||||
'**/CurrencyDisplay.tsx',
|
||||
'**/EllipsisDisplay.tsx',
|
||||
'**/ContactLink.tsx',
|
||||
'**/BooleanDisplay.tsx',
|
||||
'**/LinksDisplay.tsx',
|
||||
'**/RoundedLink.tsx',
|
||||
'**/OverflowingTextWithTooltip.tsx',
|
||||
'**/Chip.tsx',
|
||||
'**/Tag.tsx',
|
||||
'**/MultiSelectFieldDisplay.tsx',
|
||||
],
|
||||
babelOptions: {
|
||||
presets: ['@babel/preset-typescript', '@babel/preset-react'],
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user