Translation followup (#9735)
Address PR comments and more progress on translation
This commit is contained in:
@ -44,9 +44,7 @@ export const ObjectFilterDropdownOperandDropdown = ({
|
||||
dropdownHotkeyScope={{
|
||||
scope: FiltersHotkeyScope.ObjectFilterDropdownOperandDropdown,
|
||||
}}
|
||||
dropdownOffset={{
|
||||
x: parseInt(theme.spacing(2), 10),
|
||||
}}
|
||||
dropdownOffset={{ x: parseInt(theme.spacing(2), 10) }}
|
||||
/>
|
||||
);
|
||||
};
|
||||
|
||||
@ -13,9 +13,7 @@ export const RecordFieldInputScope = ({
|
||||
}: RecordFieldInputScopeProps) => {
|
||||
return (
|
||||
<RecordFieldInputScopeInternalContext.Provider
|
||||
value={{
|
||||
scopeId: recordFieldInputScopeId,
|
||||
}}
|
||||
value={{ scopeId: recordFieldInputScopeId }}
|
||||
>
|
||||
{children}
|
||||
</RecordFieldInputScopeInternalContext.Provider>
|
||||
|
||||
@ -130,7 +130,11 @@ export const useRecordShowPagePagination = (
|
||||
!isFirstRecord || (isFirstRecord && cacheIsAvailableForNavigation);
|
||||
|
||||
const navigateToPreviousRecord = () => {
|
||||
if (isFirstRecord || !recordBefore) {
|
||||
if (loading) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (isFirstRecord) {
|
||||
if (cacheIsAvailableForNavigation) {
|
||||
const lastRecordIdFromCache =
|
||||
recordIdsInCache[recordIdsInCache.length - 1];
|
||||
@ -164,7 +168,11 @@ export const useRecordShowPagePagination = (
|
||||
!isLastRecord || (isLastRecord && cacheIsAvailableForNavigation);
|
||||
|
||||
const navigateToNextRecord = () => {
|
||||
if (isLastRecord || !recordAfter) {
|
||||
if (loading) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (isLastRecord) {
|
||||
if (cacheIsAvailableForNavigation) {
|
||||
const firstRecordIdFromCache = recordIdsInCache[0];
|
||||
|
||||
|
||||
@ -229,9 +229,7 @@ export const RecordDetailRelationSection = ({
|
||||
)}
|
||||
</RecordPickerComponentInstanceContext.Provider>
|
||||
}
|
||||
dropdownHotkeyScope={{
|
||||
scope: dropdownId,
|
||||
}}
|
||||
dropdownHotkeyScope={{ scope: dropdownId }}
|
||||
/>
|
||||
</DropdownScope>
|
||||
)
|
||||
|
||||
@ -11,6 +11,7 @@ import { graphqlMocks } from '~/testing/graphqlMocks';
|
||||
import { getCompaniesMock } from '~/testing/mock-data/companies';
|
||||
import { getPeopleMock } from '~/testing/mock-data/people';
|
||||
|
||||
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
|
||||
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';
|
||||
import { RecordDetailRelationSection } from '../RecordDetailRelationSection';
|
||||
|
||||
@ -52,6 +53,7 @@ const meta: Meta<typeof RecordDetailRelationSection> = {
|
||||
ObjectMetadataItemsDecorator,
|
||||
SnackBarDecorator,
|
||||
MemoryRouterDecorator,
|
||||
I18nFrontDecorator,
|
||||
],
|
||||
parameters: {
|
||||
msw: graphqlMocks,
|
||||
|
||||
@ -1,5 +1,6 @@
|
||||
import { useAggregateRecordsForRecordTableColumnFooter } from '@/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter';
|
||||
import styled from '@emotion/styled';
|
||||
import { Trans } from '@lingui/react/macro';
|
||||
import { isDefined, OverflowingTextWithTooltip } from 'twenty-ui';
|
||||
|
||||
const StyledText = styled.span`
|
||||
@ -67,7 +68,9 @@ export const RecordTableColumnAggregateFooterValue = ({
|
||||
)}
|
||||
</StyledValueContainer>
|
||||
) : (
|
||||
<StyledText id={sanitizedId}>Calculate</StyledText>
|
||||
<StyledText id={sanitizedId}>
|
||||
<Trans>Calculate</Trans>
|
||||
</StyledText>
|
||||
)}
|
||||
</>
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user