Translation followup (#9735)

Address PR comments and more progress on translation
This commit is contained in:
Félix Malfait
2025-01-19 13:29:19 +01:00
committed by GitHub
parent 052331685f
commit 056cb7c66d
97 changed files with 3981 additions and 402 deletions

View File

@ -44,9 +44,7 @@ export const ObjectFilterDropdownOperandDropdown = ({
dropdownHotkeyScope={{
scope: FiltersHotkeyScope.ObjectFilterDropdownOperandDropdown,
}}
dropdownOffset={{
x: parseInt(theme.spacing(2), 10),
}}
dropdownOffset={{ x: parseInt(theme.spacing(2), 10) }}
/>
);
};

View File

@ -13,9 +13,7 @@ export const RecordFieldInputScope = ({
}: RecordFieldInputScopeProps) => {
return (
<RecordFieldInputScopeInternalContext.Provider
value={{
scopeId: recordFieldInputScopeId,
}}
value={{ scopeId: recordFieldInputScopeId }}
>
{children}
</RecordFieldInputScopeInternalContext.Provider>

View File

@ -130,7 +130,11 @@ export const useRecordShowPagePagination = (
!isFirstRecord || (isFirstRecord && cacheIsAvailableForNavigation);
const navigateToPreviousRecord = () => {
if (isFirstRecord || !recordBefore) {
if (loading) {
return;
}
if (isFirstRecord) {
if (cacheIsAvailableForNavigation) {
const lastRecordIdFromCache =
recordIdsInCache[recordIdsInCache.length - 1];
@ -164,7 +168,11 @@ export const useRecordShowPagePagination = (
!isLastRecord || (isLastRecord && cacheIsAvailableForNavigation);
const navigateToNextRecord = () => {
if (isLastRecord || !recordAfter) {
if (loading) {
return;
}
if (isLastRecord) {
if (cacheIsAvailableForNavigation) {
const firstRecordIdFromCache = recordIdsInCache[0];

View File

@ -229,9 +229,7 @@ export const RecordDetailRelationSection = ({
)}
</RecordPickerComponentInstanceContext.Provider>
}
dropdownHotkeyScope={{
scope: dropdownId,
}}
dropdownHotkeyScope={{ scope: dropdownId }}
/>
</DropdownScope>
)

View File

@ -11,6 +11,7 @@ import { graphqlMocks } from '~/testing/graphqlMocks';
import { getCompaniesMock } from '~/testing/mock-data/companies';
import { getPeopleMock } from '~/testing/mock-data/people';
import { I18nFrontDecorator } from '~/testing/decorators/I18nFrontDecorator';
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';
import { RecordDetailRelationSection } from '../RecordDetailRelationSection';
@ -52,6 +53,7 @@ const meta: Meta<typeof RecordDetailRelationSection> = {
ObjectMetadataItemsDecorator,
SnackBarDecorator,
MemoryRouterDecorator,
I18nFrontDecorator,
],
parameters: {
msw: graphqlMocks,

View File

@ -1,5 +1,6 @@
import { useAggregateRecordsForRecordTableColumnFooter } from '@/object-record/record-table/record-table-footer/hooks/useAggregateRecordsForRecordTableColumnFooter';
import styled from '@emotion/styled';
import { Trans } from '@lingui/react/macro';
import { isDefined, OverflowingTextWithTooltip } from 'twenty-ui';
const StyledText = styled.span`
@ -67,7 +68,9 @@ export const RecordTableColumnAggregateFooterValue = ({
)}
</StyledValueContainer>
) : (
<StyledText id={sanitizedId}>Calculate</StyledText>
<StyledText id={sanitizedId}>
<Trans>Calculate</Trans>
</StyledText>
)}
</>
);