admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Store the current flow definition in a state to not depend on a specific workflow version (#10352)

Browse Source 
This PR introduces a new Recoil state to store the flow.

A few parts of the application need to know the definition of the
current flow. Previously, we stored the workflow version's ID and
fetched its definition with the `useWorkflowVersion` hook. However, we
must use another strategy to visualize workflow runs. Indeed, we now
store the definition of the workflow in the workflow run output when it
is executed. This is useful for draft versions, which can change between
the moment they were executed and the moment they are visualized.
This commit is contained in:
Baptiste Devessier
2025-02-20 17:12:03 +01:00
committed by GitHub
parent d96865abc3
commit 05d00e6604
14 changed files with 180 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
packages/twenty-front/src/modules/workflow/workflow-variables/hooks/useAvailableVariablesInWorkflowStep.ts
View File

@ -1,3 +1,4 @@
import { useFlowOrThrow } from '@/workflow/hooks/useFlowOrThrow';
import { useWorkflowWithCurrentVersion } from '@/workflow/hooks/useWorkflowWithCurrentVersion';
import { workflowIdState } from '@/workflow/states/workflowIdState';
import { getStepDefinitionOrThrow } from '@/workflow/utils/getStepDefinitionOrThrow';
@ -24,27 +25,32 @@ export const useAvailableVariablesInWorkflowStep = ({
const workflowId = useRecoilValue(workflowIdState);
const workflow = useWorkflowWithCurrentVersion(workflowId);
const workflowSelectedNode = useRecoilValue(workflowSelectedNodeState);
const flow = useFlowOrThrow();
if (!isDefined(workflowSelectedNode) || !isDefined(workflow)) {
return [];
}
const trigger = flow.trigger;
const steps = flow.steps;
const stepDefinition = getStepDefinitionOrThrow({
stepId: workflowSelectedNode,
workflowVersion: workflow.currentVersion,
trigger,
steps,
});
if (
!isDefined(stepDefinition) ||
stepDefinition.type === 'trigger' ||
!isDefined(workflow.currentVersion.steps)
!isDefined(steps)
) {
return [];
}
const previousSteps = [];
for (const step of workflow.currentVersion.steps) {
for (const step of steps) {
if (step.id === workflowSelectedNode) {
break;
}
@ -54,34 +60,32 @@ export const useAvailableVariablesInWorkflowStep = ({
const result = [];
const filteredTriggerOutputSchema = filterOutputSchema(
workflow.currentVersion.trigger?.settings?.outputSchema as
| OutputSchema
| undefined,
trigger?.settings?.outputSchema as OutputSchema | undefined,
objectNameSingularToSelect,
);
if (
isDefined(workflow.currentVersion.trigger) &&
isDefined(trigger) &&
isDefined(filteredTriggerOutputSchema) &&
!isEmptyObject(filteredTriggerOutputSchema)
) {
const triggerIconKey =
workflow.currentVersion.trigger.type === 'DATABASE_EVENT'
trigger.type === 'DATABASE_EVENT'
? getTriggerIcon({
type: workflow.currentVersion.trigger.type,
type: trigger.type,
eventName: splitWorkflowTriggerEventName(
workflow.currentVersion.trigger.settings?.eventName,
trigger.settings?.eventName,
).event,
})
: getTriggerIcon({
type: workflow.currentVersion.trigger.type,
type: trigger.type,
});
result.push({
id: 'trigger',
name: isDefined(workflow.currentVersion.trigger.name)
? workflow.currentVersion.trigger.name
: getTriggerStepName(workflow.currentVersion.trigger),
name: isDefined(trigger.name)
? trigger.name
: getTriggerStepName(trigger),
icon: triggerIconKey,
outputSchema: filteredTriggerOutputSchema,
});