admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add no-console eslint rule (#1890)

Browse Source 
* Add no-console eslint rule

* Remove unused test
This commit is contained in:
Charles Bochet
2023-10-05 21:16:02 +02:00
committed by GitHub
parent 922f8eca0e
commit 07450df1a1
24 changed files with 69 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
front/src/modules/apollo/services/apollo.factory.ts
View File

@ -15,6 +15,7 @@ import { createUploadLink } from 'apollo-upload-client';
import { renewToken } from '@/auth/services/AuthService';
import { AuthTokenPair } from '~/generated/graphql';
import { assertNotNull } from '~/utils/assert';
import { logDebug } from '~/utils/logDebug';
import { ApolloManager } from '../types/apolloManager.interface';
import { loggerLink } from '../utils';
@ -105,7 +106,7 @@ export class ApolloFactory<TCacheShape> implements ApolloManager<TCacheShape> {
}
default:
if (isDebugMode) {
console.warn(
logDebug(
`[GraphQL error]: Message: ${
graphQLError.message
}, Location: ${
@ -121,7 +122,7 @@ export class ApolloFactory<TCacheShape> implements ApolloManager<TCacheShape> {
if (networkError) {
if (isDebugMode) {
console.warn(`[Network error]: ${networkError}`);
logDebug(`[Network error]: ${networkError}`);
}
onNetworkError?.(networkError);
}

23
front/src/modules/apollo/utils/index.ts
View File

@ -1,5 +1,8 @@
import { ApolloLink, gql, Operation } from '@apollo/client';
import { logDebug } from '~/utils/logDebug';
import { logError } from '~/utils/logError';
import formatTitle from './format-title';
const getGroup = (collapsed: boolean) =>
@ -36,10 +39,10 @@ export const loggerLink = (getSchemaName: (operation: Operation) => string) =>
console.groupCollapsed(...titleArgs);
if (variables && Object.keys(variables).length !== 0) {
console.log('VARIABLES', variables);
logDebug('VARIABLES', variables);
}
console.log('QUERY', query);
logDebug('QUERY', query);
console.groupEnd();
@ -64,7 +67,7 @@ export const loggerLink = (getSchemaName: (operation: Operation) => string) =>
if (errors) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
errors.forEach((err: any) => {
console.log(
logDebug(
`%c${err.message}`,
// eslint-disable-next-line twenty/no-hardcoded-colors
'color: #F51818; font-weight: lighter',
@ -72,29 +75,29 @@ export const loggerLink = (getSchemaName: (operation: Operation) => string) =>
});
}
console.log('HEADERS: ', headers);
logDebug('HEADERS: ', headers);
if (variables && Object.keys(variables).length !== 0) {
console.log('VARIABLES', variables);
logDebug('VARIABLES', variables);
}
console.log('QUERY', query);
logDebug('QUERY', query);
if (result.data) {
console.log('RESULT', result.data);
logDebug('RESULT', result.data);
}
if (errors) {
console.log('ERRORS', errors);
logDebug('ERRORS', errors);
}
console.groupEnd();
} catch {
// this may happen if console group is not supported
console.log(
logDebug(
`${operationType} ${schemaName}::${queryName} (in ${time} ms)`,
);
if (errors) {
console.error(errors);
logError(errors);
}
}