admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix open api specs for MULTI_SELECT (#8494)

Browse Source 
## Before

![image](https://github.com/user-attachments/assets/b7384fb3-0f32-498b-99bb-27b8c15db00c)

## After

![image](https://github.com/user-attachments/assets/a8429849-559d-4494-8636-e5a6ddda7b47)
This commit is contained in:
martmull
2024-11-14 12:07:31 +01:00
committed by GitHub
parent 9ac949dec8
commit 090f612c4b
2 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/components.utils.spec.ts
View File

@ -125,8 +125,8 @@ describe('computeSchemaComponents', () => {
enum: ['OPTION_1', 'OPTION_2'], enum: ['OPTION_1', 'OPTION_2'],
}, },
fieldMultiSelect: { fieldMultiSelect: {
type: 'string', type: 'array',
enum: ['OPTION_1', 'OPTION_2'], items: { type: 'string', enum: ['OPTION_1', 'OPTION_2'] },
}, },
fieldPosition: { fieldPosition: {
type: 'number', type: 'number',
@ -302,8 +302,8 @@ describe('computeSchemaComponents', () => {
enum: ['OPTION_1', 'OPTION_2'], enum: ['OPTION_1', 'OPTION_2'],
}, },
fieldMultiSelect: { fieldMultiSelect: {
type: 'string', type: 'array',
enum: ['OPTION_1', 'OPTION_2'], items: { type: 'string', enum: ['OPTION_1', 'OPTION_2'] },
}, },
fieldPosition: { fieldPosition: {
type: 'number', type: 'number',
@ -478,8 +478,8 @@ describe('computeSchemaComponents', () => {
enum: ['OPTION_1', 'OPTION_2'], enum: ['OPTION_1', 'OPTION_2'],
}, },
fieldMultiSelect: { fieldMultiSelect: {
type: 'string', type: 'array',
enum: ['OPTION_1', 'OPTION_2'], items: { type: 'string', enum: ['OPTION_1', 'OPTION_2'] },
}, },
fieldPosition: { fieldPosition: {
type: 'number', type: 'number',

12
packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts
View File

@ -115,8 +115,18 @@ const getSchemaComponentsProperties = ({
let itemProperty = {} as Property; let itemProperty = {} as Property;
switch (field.type) { switch (field.type) {
case FieldMetadataType.SELECT:
case FieldMetadataType.MULTI_SELECT: case FieldMetadataType.MULTI_SELECT:
itemProperty = {
type: 'array',
items: {
type: 'string',
enum: field.options.map(
(option: { value: string }) => option.value,
),
},
};
break;
case FieldMetadataType.SELECT:
itemProperty = { itemProperty = {
type: 'string', type: 'string',
enum: field.options.map((option: { value: string }) => option.value), enum: field.options.map((option: { value: string }) => option.value),