admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor/context and scopes (#1602)

Browse Source 
* Put onImport in a context

* Refactored RecoilScopeContexts

* Refactored naming

* Fix tests

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Lucas Bordeau
2023-09-15 21:51:46 +02:00
committed by GitHub
parent d07474ece7
commit 0a7a0ac6cb
102 changed files with 639 additions and 552 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
front/src/modules/activities/editable-fields/components/ActivityAssigneeEditableField.tsx
View File

@ -16,7 +16,7 @@ type OwnProps = {
export function ActivityAssigneeEditableField({ activity }: OwnProps) {
return (
<RecoilScope SpecificContext={FieldRecoilScopeContext}>
<RecoilScope CustomRecoilScopeContext={FieldRecoilScopeContext}>
<RecoilScope>
<EditableField
customEditHotkeyScope={{

2
front/src/modules/activities/editable-fields/components/ActivityRelationEditableField.tsx
View File

@ -21,7 +21,7 @@ type OwnProps = {
export function ActivityRelationEditableField({ activity }: OwnProps) {
return (
<RecoilScope SpecificContext={FieldRecoilScopeContext}>
<RecoilScope CustomRecoilScopeContext={FieldRecoilScopeContext}>
<RecoilScope>
<EditableField
useEditButton

2
front/src/modules/activities/tasks/__stories__/TaskGroups.stories.tsx
View File

@ -12,7 +12,7 @@ const meta: Meta<typeof TaskGroups> = {
decorators: [ComponentWithRouterDecorator, ComponentWithRecoilScopeDecorator],
parameters: {
msw: graphqlMocks,
recoilScopeContext: TasksRecoilScopeContext,
customRecoilScopeContext: TasksRecoilScopeContext,
},
};

2
front/src/modules/activities/tasks/__stories__/TaskGroupsWithoutTasks.stories.tsx
View File

@ -15,7 +15,7 @@ const meta: Meta<typeof TaskGroups> = {
decorators: [ComponentWithRouterDecorator, ComponentWithRecoilScopeDecorator],
parameters: {
msw: graphqlMocks,
recoilScopeContext: TasksRecoilScopeContext,
customRecoilScopeContext: TasksRecoilScopeContext,
},
};

2
front/src/modules/activities/tasks/components/EntityTasks.tsx
View File

@ -16,7 +16,7 @@ const StyledContainer = styled.div`
export function EntityTasks({ entity }: { entity: ActivityTargetableEntity }) {
return (
<StyledContainer>
<RecoilScope SpecificContext={TasksRecoilScopeContext}>
<RecoilScope CustomRecoilScopeContext={TasksRecoilScopeContext}>
<TaskGroups entity={entity} showAddButton />
</RecoilScope>
</StyledContainer>

2
front/src/modules/activities/tasks/components/PageAddTaskButton.tsx
View File

@ -27,7 +27,7 @@ export function PageAddTaskButton() {
}
return (
<RecoilScope SpecificContext={DropdownRecoilScopeContext}>
<RecoilScope CustomRecoilScopeContext={DropdownRecoilScopeContext}>
<PageAddButton onClick={handleClick} />
</RecoilScope>
);