admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix linter and remove console logs

Browse Source
This commit is contained in:
Charles Bochet
2023-11-20 16:54:51 +01:00
parent 189586830e
commit 0ace17df82
16 changed files with 57 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
front/src/modules/object-record/components/RecordShowPage.tsx
View File

@ -35,9 +35,11 @@ export const RecordShowPage = () => {
objectMetadataId: string;
}>();
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem({
objectNameSingular,
});
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem(
{
objectNameSingular,
},
);
const { favorites, createFavorite, deleteFavorite } = useFavorites({
objectNamePlural: foundObjectMetadataItem?.namePlural,

8
front/src/modules/object-record/components/RecordTableContainer.tsx
View File

@ -32,9 +32,11 @@ export const RecordTableContainer = ({
}: {
objectNamePlural: string;
}) => {
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem({
objectNamePlural,
});
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem(
{
objectNamePlural,
},
);
const { columnDefinitions } = useComputeDefinitionsFromFieldMetadata(
foundObjectMetadataItem,
);

13
front/src/modules/object-record/hooks/useFindManyObjectRecords.ts
View File

@ -48,11 +48,14 @@ export const useFindManyObjectRecords = <
isFetchingMoreObjectsFamilyState(objectNamePlural),
);
const { objectMetadataItem: foundObjectMetadataItem, objectNotFoundInMetadata, findManyQuery } =
useObjectMetadataItem({
objectNamePlural,
skip,
});
const {
objectMetadataItem: foundObjectMetadataItem,
objectNotFoundInMetadata,
findManyQuery,
} = useObjectMetadataItem({
objectNamePlural,
skip,
});
const { enqueueSnackBar } = useSnackBar();

11
front/src/modules/object-record/hooks/useFindOneObjectRecord.ts
View File

@ -15,10 +15,13 @@ export const useFindOneObjectRecord = <
onCompleted?: (data: ObjectType) => void;
skip?: boolean;
}) => {
const { objectMetadataItem: foundObjectMetadataItem, objectNotFoundInMetadata, findOneQuery } =
useObjectMetadataItem({
objectNameSingular,
});
const {
objectMetadataItem: foundObjectMetadataItem,
objectNotFoundInMetadata,
findOneQuery,
} = useObjectMetadataItem({
objectNameSingular,
});
const { data, loading, error } = useQuery<
{ [nameSingular: string]: ObjectType },

8
front/src/modules/object-record/hooks/useObjectRecordTable.ts
View File

@ -14,9 +14,11 @@ import { useFindManyObjectRecords } from './useFindManyObjectRecords';
export const useObjectRecordTable = () => {
const { scopeId: objectNamePlural } = useRecordTable();
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem({
objectNamePlural,
});
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem(
{
objectNamePlural,
},
);
const { registerOptimisticEffect } = useOptimisticEffect({
objectNameSingular: foundObjectMetadataItem?.nameSingular,

8
front/src/modules/object-record/hooks/useRecordTableContextMenuEntries.tsx
View File

@ -29,9 +29,11 @@ export const useRecordTableContextMenuEntries = () => {
const { scopeId: objectNamePlural, resetTableRowSelection } =
useRecordTable();
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem({
objectNamePlural,
});
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem(
{
objectNamePlural,
},
);
const { createFavorite, deleteFavorite, favorites } = useFavorites({
objectNamePlural,

1
front/src/modules/object-record/utils/mapPaginatedObjectsToObjects.ts
View File

@ -15,7 +15,6 @@ export const mapPaginatedObjectsToObjects = <
pagedObjects: ObjectTypeQuery | undefined;
objectNamePlural: string;
}) => {
console.log(objectNamePlural);
const formattedObjects: ObjectType[] =
pagedObjects?.[objectNamePlural].edges.map((objectEdge: ObjectEdge) => ({
...objectEdge.node,

30
front/src/modules/people/hooks/useSpreadsheetPersonImport.ts
View File

@ -1,8 +1,5 @@
import { v4 as uuidv4 } from 'uuid';
import { useSpreadsheetImport } from '@/spreadsheet-import/hooks/useSpreadsheetImport';
import { SpreadsheetOptions } from '@/spreadsheet-import/types';
import { useSnackBar } from '@/ui/feedback/snack-bar/hooks/useSnackBar';
import { fieldsForPerson } from '../utils/fieldsForPerson';
@ -10,7 +7,6 @@ export type FieldPersonMapping = (typeof fieldsForPerson)[number]['key'];
export const useSpreadsheetPersonImport = () => {
const { openSpreadsheetImport } = useSpreadsheetImport<FieldPersonMapping>();
const { enqueueSnackBar } = useSnackBar();
const openPersonSpreadsheetImport = (
options?: Omit<
@ -20,20 +16,19 @@ export const useSpreadsheetPersonImport = () => {
) => {
openSpreadsheetImport({
...options,
onSubmit: async (data) => {
onSubmit: async (_data) => {
// TODO: Add better type checking in spreadsheet import later
const createInputs = data.validData.map((person) => ({
id: uuidv4(),
firstName: person.firstName as string | undefined,
lastName: person.lastName as string | undefined,
email: person.email as string | undefined,
linkedinUrl: person.linkedinUrl as string | undefined,
xUrl: person.xUrl as string | undefined,
jobTitle: person.jobTitle as string | undefined,
phone: person.phone as string | undefined,
city: person.city as string | undefined,
}));
// const createInputs = data.validData.map((person) => ({
// id: uuidv4(),
// firstName: person.firstName as string | undefined,
// lastName: person.lastName as string | undefined,
// email: person.email as string | undefined,
// linkedinUrl: person.linkedinUrl as string | undefined,
// xUrl: person.xUrl as string | undefined,
// jobTitle: person.jobTitle as string | undefined,
// phone: person.phone as string | undefined,
// city: person.city as string | undefined,
// }));
// TODO : abstract this part for any object
// try {
// const result = await createManyPerson({
@ -42,7 +37,6 @@ export const useSpreadsheetPersonImport = () => {
// },
// refetchQueries: 'active',
// });
// if (result.errors) {
// throw result.errors;
// }

34
front/src/modules/ui/object/field/meta-types/display/content-display/components/ChipDisplay.tsx
View File

@ -1,34 +0,0 @@
type ChipDisplayProps = {
displayName: string;
entityId: string | null;
avatarUrlValue?: string;
};
export const ChipDisplay = ({
displayName,
entityId,
avatarUrlValue,
}: ChipDisplayProps) => {
switch (true) {
// case Entity.Company: {
// return (
// <CompanyChip
// id={entityId ?? ''}
// name={displayName}
// avatarUrl={getLogoUrlFromDomainName(avatarUrlValue)}
// />
// );
// }
// case Entity.Person: {
// return (
// <PersonChip
// id={entityId ?? ''}
// name={displayName}
// avatarUrl={avatarUrlValue}
// />
// );
// }
default:
return <> </>;
}
};

8
front/src/modules/ui/object/record-table/components/RecordTableBody.tsx
View File

@ -22,9 +22,11 @@ export const RecordTableBody = () => {
const { scopeId: objectNamePlural } = useRecordTable();
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem({
objectNamePlural,
});
const { objectMetadataItem: foundObjectMetadataItem } = useObjectMetadataItem(
{
objectNamePlural,
},
);
const [isFetchingMoreObjects] = useRecoilState(
isFetchingMoreObjectsFamilyState(foundObjectMetadataItem?.namePlural),