Remove localization feature flag and improve CI workflow (#10208)

.github/workflows/i18n-compile.yaml

@@ -1,50 +0,0 @@
-name: 'Compile translations'
-
-on:
-  push:
-    branches: ['i18n']
-  pull_request:
-    branches: ['i18n']
-  workflow_dispatch:
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
-  cancel-in-progress: true
-
-jobs:
-  compile_translations:
-    name: Compile translations
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-      pull-requests: write
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          token: ${{ github.token }}
-          ref: i18n
-
-      - name: Install dependencies
-        uses: ./.github/workflows/actions/yarn-install
-
-      - name: Build twenty-shared
-        run: npx nx build twenty-shared
-
-      - name: Compile translations
-        id: compile_translations
-        run: |
-          npx nx run twenty-server:lingui:compile
-          npx nx run twenty-emails:lingui:compile 
-          npx nx run twenty-front:lingui:compile
-
-      - name: Check and commit compiled files
-        run: |
-          git config --global user.name 'github-actions'
-          git config --global user.email 'github-actions@twenty.com'
-          git add .
-          if ! git diff --staged --quiet --exit-code; then
-            git commit -m "chore: compile translations [skip ci]"
-            git push origin HEAD:i18n
-          fi

.github/workflows/i18n-pull.yaml

@@ -80,8 +80,37 @@ jobs:
           github_base_url: 'github.com'
           github_user_name: 'Crowdin Bot'
           github_user_email: 'support+bot@crowdin.com'
-
         env:
           GITHUB_TOKEN: ${{ github.token }}
           CROWDIN_PROJECT_ID: '1'
           CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
+
+      - name: Compile translations
+        if: inputs.force_pull || steps.compile_translations.outcome == 'failure'
+        run: |
+          npx nx run twenty-server:lingui:compile
+          npx nx run twenty-emails:lingui:compile 
+          npx nx run twenty-front:lingui:compile
+
+      - name: Check and commit compiled files
+        id: check_changes
+        run: |
+          git config --global user.name 'github-actions'
+          git config --global user.email 'github-actions@twenty.com'
+          git add .
+          if ! git diff --staged --quiet --exit-code; then
+            git commit -m "chore: compile translations [skip ci]"
+            echo "changes_detected=true" >> $GITHUB_OUTPUT
+          else
+            echo "changes_detected=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Push changes
+        if: steps.check_changes.outputs.changes_detected == 'true'
+        run: git push origin HEAD:i18n
+
+      - name: Create pull request
+        if: steps.check_changes.outputs.changes_detected == 'true'
+        run: gh pr create -B main -H i18n --title 'i18n - translations' --body 'Created by Github action' || true
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/i18n-push.yaml

@@ -28,6 +28,7 @@ jobs:
           if ! git ls-remote --heads origin i18n | grep i18n; then
             git checkout -b i18n
           else
+            git fetch origin i18n
             git checkout i18n
             git merge origin/main
           fi
@@ -44,6 +45,12 @@ jobs:
           npx nx run twenty-emails:lingui:extract
           npx nx run twenty-front:lingui:extract
 
+      - name: Compile translations
+        run: |
+          npx nx run twenty-server:lingui:compile
+          npx nx run twenty-emails:lingui:compile
+          npx nx run twenty-front:lingui:compile
+
       - name: Check and commit any files created
         id: check_changes
         run: |