admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

New behavior for editable fields (#1300)

Browse Source 
* New behavior for editable fields

* fix

* fix

* fix coverage

* Add tests on NotFound

* fix

* fix

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Weiko
2023-08-24 15:56:43 +02:00
committed by GitHub
parent bf05e5917d
commit 10b68618d3
17 changed files with 134 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
front/src/modules/activities/editable-fields/components/ActivityRelationEditableField.tsx
View File

@ -36,6 +36,7 @@ export function ActivityRelationEditableField({ activity }: OwnProps) {
displayModeContent={
<ActivityTargetChips targets={activity?.activityTargets} />
}
isDisplayModeContentEmpty={activity?.activityTargets?.length === 0}
/>
</RecoilScope>
</RecoilScope>

26
front/src/modules/activities/hooks/useOpenTimelineRightDrawer.ts
View File

@ -1,26 +0,0 @@
import { useRecoilState } from 'recoil';
import { useRightDrawer } from '@/ui/right-drawer/hooks/useRightDrawer';
import { RightDrawerHotkeyScope } from '@/ui/right-drawer/types/RightDrawerHotkeyScope';
import { RightDrawerPages } from '@/ui/right-drawer/types/RightDrawerPages';
import { useSetHotkeyScope } from '@/ui/utilities/hotkey/hooks/useSetHotkeyScope';
import { activityTargetableEntityArrayState } from '../states/activityTargetableEntityArrayState';
import { ActivityTargetableEntity } from '../types/ActivityTargetableEntity';
// TODO: refactor with recoil callback to avoid rerender
export function useOpenTimelineRightDrawer() {
const { openRightDrawer } = useRightDrawer();
const [, setActivityTargetableEntityArray] = useRecoilState(
activityTargetableEntityArrayState,
);
const setHotkeyScope = useSetHotkeyScope();
return function openTimelineRightDrawer(
activityTargetableEntityArray: ActivityTargetableEntity[],
) {
setHotkeyScope(RightDrawerHotkeyScope.RightDrawer, { goto: false });
setActivityTargetableEntityArray(activityTargetableEntityArray);
openRightDrawer(RightDrawerPages.Timeline);
};
}

24
front/src/modules/activities/right-drawer/components/RightDrawerTimeline.tsx
View File

@ -1,24 +0,0 @@
import { useRecoilValue } from 'recoil';
import { activityTargetableEntityArrayState } from '@/activities/states/activityTargetableEntityArrayState';
import { Timeline } from '@/activities/timeline/components/Timeline';
export function RightDrawerTimeline() {
const activityTargetableEntityArray = useRecoilValue(
activityTargetableEntityArrayState,
);
return (
<>
{activityTargetableEntityArray.map((targetableEntity) => (
<Timeline
key={targetableEntity.id}
entity={{
id: targetableEntity?.id ?? '',
type: targetableEntity.type,
}}
/>
))}
</>
);
}