Improve Board performances (#2626)

Improve app performances

front/src/modules/companies/board/components/CompanyBoard.tsx

@@ -1,5 +1,4 @@
 import styled from '@emotion/styled';
-import { useSetRecoilState } from 'recoil';
 
 import { BoardContext } from '@/companies/states/contexts/BoardContext';
 import { BoardOptionsDropdown } from '@/ui/layout/board/components/BoardOptionsDropdown';
@@ -11,7 +10,6 @@ import {
 import { EntityBoardActionBar } from '@/ui/layout/board/components/EntityBoardActionBar';
 import { EntityBoardContextMenu } from '@/ui/layout/board/components/EntityBoardContextMenu';
 import { ViewBar } from '@/views/components/ViewBar';
-import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates';
 import { ViewScope } from '@/views/scopes/ViewScope';
 import { opportunitiesBoardOptions } from '~/pages/opportunities/opportunitiesBoardOptions';
 
@@ -38,30 +36,12 @@ export const CompanyBoard = ({
 }: CompanyBoardProps) => {
   const viewScopeId = 'company-board-view';
 
-  const {
-    currentViewFieldsState,
-    currentViewFiltersState,
-    currentViewSortsState,
-  } = useViewScopedStates({
-    customViewScopeId: viewScopeId,
-  });
-
-  const setCurrentViewFields = useSetRecoilState(currentViewFieldsState);
-  const setCurrentViewFilters = useSetRecoilState(currentViewFiltersState);
-  const setCurrentViewSorts = useSetRecoilState(currentViewSortsState);
-
   return (
     <ViewScope
       viewScopeId={viewScopeId}
-      onViewFieldsChange={(viewFields) => {
-        setCurrentViewFields(viewFields);
-      }}
-      onViewFiltersChange={(viewFilters) => {
-        setCurrentViewFilters(viewFilters);
-      }}
-      onViewSortsChange={(viewSorts) => {
-        setCurrentViewSorts(viewSorts);
-      }}
+      onViewFieldsChange={() => {}}
+      onViewFiltersChange={() => {}}
+      onViewSortsChange={() => {}}
     >
       <StyledContainer>
         <BoardContext.Provider

front/src/modules/companies/components/CompanyBoardCard.tsx

@@ -127,7 +127,7 @@ const StyledCompactIconContainer = styled.div`
 export const CompanyBoardCard = () => {
   const { BoardRecoilScopeContext } = useBoardContext();
 
-  const { currentCardSelected, setCurrentCardSelected } =
+  const { isCurrentCardSelected, setCurrentCardSelected } =
     useCurrentCardSelected();
   const boardCardId = useContext(BoardCardIdContext);
 
@@ -200,9 +200,9 @@ export const CompanyBoardCard = () => {
   return (
     <StyledBoardCardWrapper>
       <StyledBoardCard
-        selected={currentCardSelected}
+        selected={isCurrentCardSelected}
         onMouseLeave={OnMouseLeaveBoard}
-        onClick={() => setCurrentCardSelected(!currentCardSelected)}
+        onClick={() => setCurrentCardSelected(!isCurrentCardSelected)}
       >
         <StyledBoardCardHeader showCompactView={showCompactView}>
           <CompanyChip
@@ -225,8 +225,8 @@ export const CompanyBoardCard = () => {
           )}
           <StyledCheckboxContainer className="checkbox-container">
             <Checkbox
-              checked={currentCardSelected}
-              onChange={() => setCurrentCardSelected(!currentCardSelected)}
+              checked={isCurrentCardSelected}
+              onChange={() => setCurrentCardSelected(!isCurrentCardSelected)}
               variant={CheckboxVariant.Secondary}
             />
           </StyledCheckboxContainer>

front/src/modules/companies/components/HooksCompanyBoardEffect.tsx

@@ -164,21 +164,19 @@ export const HooksCompanyBoardEffect = () => {
     setViewType?.(ViewType.Kanban);
   }, [objectMetadataItem, setViewObjectMetadataId, setViewType]);
 
-  const loading = !companies;
-
   const { setActionBarEntries } = useBoardActionBarEntries();
   const { setContextMenuEntries } = useBoardContextMenuEntries();
 
   useEffect(() => {
-    if (!loading && opportunities && companies) {
+    if (opportunities && companies) {
       setActionBarEntries();
       setContextMenuEntries();
+
       updateCompanyBoard(pipelineSteps, opportunities, companies);
       setEntityCountInCurrentView(opportunities.length);
     }
   }, [
     companies,
-    loading,
     opportunities,
     pipelineSteps,
     setActionBarEntries,

front/src/modules/companies/hooks/useUpdateCompanyBoardColumns.ts

@@ -105,7 +105,10 @@ export const useUpdateCompanyBoard = () =>
               position: pipelineStep.position ?? 0,
             };
           });
-        if (currentBoardColumns.length === 0) {
+        if (
+          currentBoardColumns.length === 0 &&
+          !isDeeplyEqual(newBoardColumns, currentBoardColumns)
+        ) {
           set(boardColumnsState, newBoardColumns);
           set(savedBoardColumnsState, newBoardColumns);
         }