From 110d5eaa9d9e2e19dce1c7ba54f88e347c5a4947 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tha=C3=AFs?= <guigon.thais@gmail.com>
Date: Mon, 11 Sep 2023 12:03:01 +0200
Subject: [PATCH] feat: only show Update View button if view can be persisted
 (#1533)

Closes #1499
---
 .../view-bar/components/UpdateViewButtonGroup.tsx | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/front/src/modules/ui/view-bar/components/UpdateViewButtonGroup.tsx b/front/src/modules/ui/view-bar/components/UpdateViewButtonGroup.tsx
index 64546ab5c..878a461fe 100644
--- a/front/src/modules/ui/view-bar/components/UpdateViewButtonGroup.tsx
+++ b/front/src/modules/ui/view-bar/components/UpdateViewButtonGroup.tsx
@@ -67,6 +67,10 @@ export const UpdateViewButtonGroup = ({
 
   const setViewEditMode = useSetRecoilState(viewEditModeState);
 
+  const canPersistView =
+    currentViewId &&
+    (canPersistViewFields || canPersistFilters || canPersistSorts);
+
   const handleArrowDownButtonClick = useCallback(() => {
     setIsDropdownOpen((previousIsOpen) => !previousIsOpen);
   }, []);
@@ -95,17 +99,12 @@ export const UpdateViewButtonGroup = ({
     [],
   );
 
+  if (!canPersistView) return null;
+
   return (
     <StyledContainer>
       <ButtonGroup size="small" accent="blue">
-        <Button
-          title="Update view"
-          disabled={
-            !currentViewId ||
-            (!canPersistViewFields && !canPersistFilters && !canPersistSorts)
-          }
-          onClick={handleViewSubmit}
-        />
+        <Button title="Update view" onClick={handleViewSubmit} />
         <Button
           size="small"
           Icon={IconChevronDown}