From 117e502e80b9152327acc895c2b9502b6edf01ab Mon Sep 17 00:00:00 2001
From: Thomas Trompette <thomas.trompette@sfr.fr>
Date: Wed, 6 Nov 2024 16:54:23 +0100
Subject: [PATCH] Clean available fields in variable dropdown (#8371)

As title

We do not want relations yet in picker
---
 .../src/modules/workflow/types/Workflow.ts           |  2 +-
 .../utils/generate-fake-object-record.ts             |  5 +++++
 .../utils/should-generate-field-fake-value.ts        | 12 ++++++++++++
 3 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 packages/twenty-server/src/modules/workflow/workflow-builder/utils/should-generate-field-fake-value.ts

diff --git a/packages/twenty-front/src/modules/workflow/types/Workflow.ts b/packages/twenty-front/src/modules/workflow/types/Workflow.ts
index 6905e796e..75235034f 100644
--- a/packages/twenty-front/src/modules/workflow/types/Workflow.ts
+++ b/packages/twenty-front/src/modules/workflow/types/Workflow.ts
@@ -16,7 +16,7 @@ export type WorkflowCodeStepSettings = BaseWorkflowStepSettings & {
     serverlessFunctionId: string;
     serverlessFunctionVersion: string;
     serverlessFunctionInput: {
-      [hello: string]: any;
+      [key: string]: any;
     };
   };
 };
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/utils/generate-fake-object-record.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/utils/generate-fake-object-record.ts
index 38c925f4e..b35b14da2 100644
--- a/packages/twenty-server/src/modules/workflow/workflow-builder/utils/generate-fake-object-record.ts
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/utils/generate-fake-object-record.ts
@@ -1,10 +1,15 @@
 import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
 import { generateFakeValue } from 'src/engine/utils/generate-fake-value';
+import { shouldGenerateFieldFakeValue } from 'src/modules/workflow/workflow-builder/utils/should-generate-field-fake-value';
 
 export const generateFakeObjectRecord = <Entity>(
   objectMetadataEntity: ObjectMetadataEntity,
 ): Entity =>
   objectMetadataEntity.fields.reduce((acc, field) => {
+    if (!shouldGenerateFieldFakeValue(field)) {
+      return acc;
+    }
+
     acc[field.name] = generateFakeValue(field.type);
 
     return acc;
diff --git a/packages/twenty-server/src/modules/workflow/workflow-builder/utils/should-generate-field-fake-value.ts b/packages/twenty-server/src/modules/workflow/workflow-builder/utils/should-generate-field-fake-value.ts
new file mode 100644
index 000000000..7315b36fe
--- /dev/null
+++ b/packages/twenty-server/src/modules/workflow/workflow-builder/utils/should-generate-field-fake-value.ts
@@ -0,0 +1,12 @@
+import {
+  FieldMetadataEntity,
+  FieldMetadataType,
+} from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
+
+export const shouldGenerateFieldFakeValue = (field: FieldMetadataEntity) => {
+  return (
+    !field.isSystem &&
+    field.isActive &&
+    field.type !== FieldMetadataType.RELATION
+  );
+};