TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354)

* ESLint rule: only take explicit boolean predicates in if statements

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix frontend linter errors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix jest

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix lint on new code

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

packages/twenty-front/src/modules/auth/hooks/useAuth.ts

@@ -26,6 +26,7 @@ import {
   useSignUpMutation,
   useVerifyMutation,
 } from '~/generated/graphql';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 import { currentUserState } from '../states/currentUserState';
 import { tokenPairState } from '../states/tokenPairState';
@@ -59,7 +60,7 @@ export const useAuth = () => {
         },
       });
 
-      if (challengeResult.errors) {
+      if (isNonNullable(challengeResult.errors)) {
         throw challengeResult.errors;
       }
 
@@ -78,7 +79,7 @@ export const useAuth = () => {
         variables: { loginToken },
       });
 
-      if (verifyResult.errors) {
+      if (isNonNullable(verifyResult.errors)) {
         throw verifyResult.errors;
       }
 
@@ -91,7 +92,7 @@ export const useAuth = () => {
       const user = verifyResult.data?.verify.user;
       let workspaceMember = null;
       setCurrentUser(user);
-      if (user.workspaceMember) {
+      if (isNonNullable(user.workspaceMember)) {
         workspaceMember = {
           ...user.workspaceMember,
           colorScheme: user.workspaceMember?.colorScheme as ColorScheme,
@@ -183,7 +184,7 @@ export const useAuth = () => {
         },
       });
 
-      if (signUpResult.errors) {
+      if (isNonNullable(signUpResult.errors)) {
         throw signUpResult.errors;
       }
 

packages/twenty-front/src/modules/auth/services/AuthService.ts

@@ -13,6 +13,8 @@ import {
   RenewTokenMutation,
   RenewTokenMutationVariables,
 } from '~/generated/graphql';
+import { isNonNullable } from '~/utils/isNonNullable';
+import { isNullable } from '~/utils/isNullable';
 
 const logger = loggerLink(() => 'Twenty-Refresh');
 
@@ -45,7 +47,7 @@ const renewTokenMutation = async (
     fetchPolicy: 'network-only',
   });
 
-  if (errors || !data) {
+  if (isNonNullable(errors) || isNullable(data)) {
     throw new Error('Something went wrong during token renewal');
   }
 
@@ -67,5 +69,5 @@ export const renewToken = async (
 
   const data = await renewTokenMutation(uri, tokenPair.refreshToken.token);
 
-  return data.renewToken.tokens;
+  return data?.renewToken.tokens;
 };

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useHandleResetPassword.ts

@@ -22,7 +22,7 @@ export const useHandleResetPassword = () => {
             variables: { email },
           });
 
-          if (data?.emailPasswordResetLink?.success) {
+          if (data?.emailPasswordResetLink?.success === true) {
             enqueueSnackBar('Password reset link has been sent to the email', {
               variant: 'success',
             });

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useNavigateAfterSignInUp.ts

@@ -16,7 +16,7 @@ export const useNavigateAfterSignInUp = () => {
       currentWorkspaceMember: WorkspaceMember | null,
     ) => {
       if (
-        billing?.isBillingEnabled &&
+        billing?.isBillingEnabled === true &&
         !['active', 'trialing'].includes(currentWorkspace.subscriptionStatus)
       ) {
         navigate(AppPath.PlanRequired);

packages/twenty-front/src/modules/auth/utils/getOnboardingStatus.ts

@@ -37,7 +37,7 @@ export const getOnboardingStatus = ({
   }
 
   if (
-    isBillingEnabled &&
+    isBillingEnabled === true &&
     currentWorkspace.subscriptionStatus === 'incomplete'
   ) {
     return OnboardingStatus.Incomplete;
@@ -54,15 +54,24 @@ export const getOnboardingStatus = ({
     return OnboardingStatus.OngoingProfileCreation;
   }
 
-  if (isBillingEnabled && currentWorkspace.subscriptionStatus === 'canceled') {
+  if (
+    isBillingEnabled === true &&
+    currentWorkspace.subscriptionStatus === 'canceled'
+  ) {
     return OnboardingStatus.Canceled;
   }
 
-  if (isBillingEnabled && currentWorkspace.subscriptionStatus === 'past_due') {
+  if (
+    isBillingEnabled === true &&
+    currentWorkspace.subscriptionStatus === 'past_due'
+  ) {
     return OnboardingStatus.PastDue;
   }
 
-  if (isBillingEnabled && currentWorkspace.subscriptionStatus === 'unpaid') {
+  if (
+    isBillingEnabled === true &&
+    currentWorkspace.subscriptionStatus === 'unpaid'
+  ) {
     return OnboardingStatus.Unpaid;
   }