admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354)

Browse Source 
* ESLint rule: only take explicit boolean predicates in if statements

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix frontend linter errors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix jest

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix lint on new code

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
This commit is contained in:
gitstart-app[bot]
2024-03-09 10:48:19 +01:00
committed by GitHub
parent 40bea0d95e
commit 17511be0cf
164 changed files with 655 additions and 367 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/twenty-front/src/modules/ui/feedback/dialog-manager/components/Dialog.tsx
View File

@ -5,6 +5,7 @@ import { Key } from 'ts-key-enum';
import { Button } from '@/ui/input/button/components/Button';
import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys';
import { isNonNullable } from '~/utils/isNonNullable';
import { DialogHotkeyScope } from '../types/DialogHotkeyScope';
@ -104,7 +105,7 @@ export const Dialog = ({
event.preventDefault();
if (confirmButton) {
if (isNonNullable(confirmButton)) {
confirmButton?.onClick?.(event);
closeSnackbar();
}

3
packages/twenty-front/src/modules/ui/feedback/snack-bar-manager/components/SnackBar.tsx
View File

@ -8,6 +8,7 @@ import {
ProgressBarControls,
} from '@/ui/feedback/progress-bar/components/ProgressBar';
import { RGBA } from '@/ui/theme/constants/Rgba';
import { isNonNullable } from '~/utils/isNonNullable';
import { usePausableTimeout } from '../hooks/usePausableTimeout';
@ -131,7 +132,7 @@ export const SnackBar = ({
);
const icon = useMemo(() => {
if (iconComponent) {
if (isNonNullable(iconComponent)) {
return iconComponent;
}

8
packages/twenty-front/src/modules/ui/feedback/snack-bar-manager/hooks/usePausableTimeout.ts
View File

@ -1,5 +1,7 @@
import { useCallback, useEffect, useRef } from 'react';
import { isNonNullable } from '~/utils/isNonNullable';
export const usePausableTimeout = (callback: () => void, delay: number) => {
// eslint-disable-next-line @nx/workspace-no-state-useref
const savedCallback = useRef<() => void>(callback);
@ -11,7 +13,7 @@ export const usePausableTimeout = (callback: () => void, delay: number) => {
const timeoutId = useRef<ReturnType<typeof setTimeout> | null>(null);
const tick = () => {
if (savedCallback.current) {
if (isNonNullable(savedCallback.current)) {
savedCallback.current();
}
};
@ -31,7 +33,7 @@ export const usePausableTimeout = (callback: () => void, delay: number) => {
if (delay !== null) {
startTimeout();
return () => {
if (timeoutId.current) {
if (isNonNullable(timeoutId.current)) {
clearTimeout(timeoutId.current);
}
};
@ -39,7 +41,7 @@ export const usePausableTimeout = (callback: () => void, delay: number) => {
}, [delay, startTimeout]);
const pauseTimeout = () => {
if (timeoutId.current) {
if (isNonNullable(timeoutId.current)) {
clearTimeout(timeoutId.current);
}
const elapsedTime = Date.now() - startTime.current;