TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354)

* ESLint rule: only take explicit boolean predicates in if statements

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix frontend linter errors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix jest

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix lint on new code

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx

@@ -14,6 +14,7 @@ import { HotkeyEffect } from '@/ui/utilities/hotkey/components/HotkeyEffect';
 import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys';
 import { HotkeyScope } from '@/ui/utilities/hotkey/types/HotkeyScope';
 import { useListenClickOutside } from '@/ui/utilities/pointer-event/hooks/useListenClickOutside';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 import { useDropdown } from '../hooks/useDropdown';
 import { useInternalHotkeyScopeManagement } from '../hooks/useInternalHotkeyScopeManagement';
@@ -59,11 +60,11 @@ export const Dropdown = ({
     useDropdown(dropdownId);
   const offsetMiddlewares = [];
 
-  if (dropdownOffset.x) {
+  if (isNonNullable(dropdownOffset.x)) {
     offsetMiddlewares.push(offset({ crossAxis: dropdownOffset.x }));
   }
 
-  if (dropdownOffset.y) {
+  if (isNonNullable(dropdownOffset.y)) {
     offsetMiddlewares.push(offset({ mainAxis: dropdownOffset.y }));
   }
 

packages/twenty-front/src/modules/ui/layout/dropdown/hooks/useDropdown.ts

@@ -3,6 +3,7 @@ import { useRecoilState } from 'recoil';
 import { useDropdownStates } from '@/ui/layout/dropdown/hooks/internal/useDropdownStates';
 import { usePreviousHotkeyScope } from '@/ui/utilities/hotkey/hooks/usePreviousHotkeyScope';
 import { getScopeIdOrUndefinedFromComponentId } from '@/ui/utilities/recoil-scope/utils/getScopeIdOrUndefinedFromComponentId';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 export const useDropdown = (dropdownId?: string) => {
   const {
@@ -35,7 +36,7 @@ export const useDropdown = (dropdownId?: string) => {
 
   const openDropdown = () => {
     setIsDropdownOpen(true);
-    if (dropdownHotkeyScope) {
+    if (isNonNullable(dropdownHotkeyScope)) {
       setHotkeyScopeAndMemorizePreviousScope(
         dropdownHotkeyScope.scope,
         dropdownHotkeyScope.customScopes,

packages/twenty-front/src/modules/ui/layout/selectable-list/components/SelectableList.tsx

@@ -4,6 +4,7 @@ import { useSelectableListHotKeys } from '@/ui/layout/selectable-list/hooks/inte
 import { useSelectableList } from '@/ui/layout/selectable-list/hooks/useSelectableList';
 import { SelectableListScope } from '@/ui/layout/selectable-list/scopes/SelectableListScope';
 import { arrayToChunks } from '~/utils/array/arrayToChunks';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 type SelectableListProps = {
   children: ReactNode;
@@ -39,11 +40,11 @@ export const SelectableList = ({
       );
     }
 
-    if (selectableItemIdMatrix) {
+    if (isNonNullable(selectableItemIdMatrix)) {
       setSelectableItemIds(selectableItemIdMatrix);
     }
 
-    if (selectableItemIdArray) {
+    if (isNonNullable(selectableItemIdArray)) {
       setSelectableItemIds(arrayToChunks(selectableItemIdArray, 1));
     }
   }, [selectableItemIdArray, selectableItemIdMatrix, setSelectableItemIds]);

packages/twenty-front/src/modules/ui/layout/selectable-list/hooks/internal/useSelectableListHotKeys.tsx

@@ -1,3 +1,4 @@
+import { isNonEmptyString } from '@sniptt/guards';
 import { useRecoilCallback } from 'recoil';
 import { Key } from 'ts-key-enum';
 
@@ -104,12 +105,12 @@ export const useSelectableListHotKeys = (
         const nextId = computeNextId(direction);
 
         if (selectedItemId !== nextId) {
-          if (nextId) {
+          if (isNonEmptyString(nextId)) {
             set(isSelectedItemIdSelector(nextId), true);
             set(selectedItemIdState(), nextId);
           }
 
-          if (selectedItemId) {
+          if (isNonEmptyString(selectedItemId)) {
             set(isSelectedItemIdSelector(selectedItemId), false);
           }
         }
@@ -144,7 +145,7 @@ export const useSelectableListHotKeys = (
             selectableListOnEnterState(),
           );
 
-          if (selectedItemId) {
+          if (isNonEmptyString(selectedItemId)) {
             onEnter?.(selectedItemId);
           }
         },

packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSummaryCard.tsx

@@ -8,6 +8,7 @@ import {
   beautifyExactDateTime,
   beautifyPastDateRelativeToNow,
 } from '~/utils/date-utils';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 type ShowPageSummaryCardProps = {
   avatarPlaceholder: string;
@@ -85,7 +86,7 @@ export const ShowPageSummaryCard = ({
   const inputFileRef = useRef<HTMLInputElement>(null);
 
   const onFileChange = (e: ChangeEvent<HTMLInputElement>) => {
-    if (e.target.files) onUploadPicture?.(e.target.files[0]);
+    if (isNonNullable(e.target.files)) onUploadPicture?.(e.target.files[0]);
   };
 
   const handleAvatarClick = () => {