admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354)

Browse Source 
* ESLint rule: only take explicit boolean predicates in if statements

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix frontend linter errors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix jest

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix lint on new code

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
This commit is contained in:
gitstart-app[bot]
2024-03-09 10:48:19 +01:00
committed by GitHub
parent 40bea0d95e
commit 17511be0cf
164 changed files with 655 additions and 367 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/twenty-front/src/modules/views/components/EditableFilterDropdownButton.tsx
View File

@ -8,6 +8,7 @@ import { HotkeyScope } from '@/ui/utilities/hotkey/types/HotkeyScope';
import { EditableFilterChip } from '@/views/components/EditableFilterChip';
import { useViewBar } from '@/views/hooks/useViewBar';
import { ViewFilter } from '@/views/types/ViewFilter';
import { isNonNullable } from '~/utils/isNonNullable';
type EditableFilterDropdownButtonProps = {
viewFilterDropdownId: string;
@ -39,7 +40,7 @@ export const EditableFilterDropdownButton = ({
filterDefinition.fieldMetadataId === viewFilter.fieldMetadataId,
);
if (filterDefinition) {
if (isNonNullable(filterDefinition)) {
setFilterDefinitionUsedInDropdown(filterDefinition);
setSelectedOperandInDropdown(viewFilter.operand);
setSelectedFilter(viewFilter);

6
packages/twenty-front/src/modules/views/components/ViewBarEffect.tsx
View File

@ -7,6 +7,8 @@ import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
import { useViewBar } from '@/views/hooks/useViewBar';
import { GraphQLView } from '@/views/types/GraphQLView';
import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
import { isNonNullable } from '~/utils/isNonNullable';
import { isNullable } from '~/utils/isNullable';
import { useViewScopedStates } from '../hooks/internal/useViewScopedStates';
@ -50,11 +52,11 @@ export const ViewBarEffect = () => {
newViews[0] ??
null;
if (!currentView) return;
if (isNullable(currentView)) return;
setCurrentViewId(currentView.id);
if (currentView?.viewFields) {
if (isNonNullable(currentView?.viewFields)) {
loadViewFields(currentView.viewFields, currentView.id);
loadViewFilters(currentView.viewFilters, currentView.id);
loadViewSorts(currentView.viewSorts, currentView.id);

5
packages/twenty-front/src/modules/views/components/ViewBarFilterEffect.tsx
View File

@ -5,6 +5,7 @@ import { useRecoilValue } from 'recoil';
import { useFilterDropdown } from '@/object-record/object-filter-dropdown/hooks/useFilterDropdown';
import { Filter } from '@/object-record/object-filter-dropdown/types/Filter';
import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates';
import { isNonNullable } from '~/utils/isNonNullable';
type ViewBarFilterEffectProps = {
filterDropdownId: string;
@ -31,11 +32,11 @@ export const ViewBarFilterEffect = ({
} = useFilterDropdown({ filterDropdownId });
useEffect(() => {
if (availableFilterDefinitions) {
if (isNonNullable(availableFilterDefinitions)) {
setAvailableFilterDefinitions(availableFilterDefinitions);
}
if (onFilterSelect) {
if (isNonNullable(onFilterSelect)) {
setOnFilterSelect(() => onFilterSelect);
}
}, [

5
packages/twenty-front/src/modules/views/components/ViewBarSortEffect.tsx
View File

@ -4,6 +4,7 @@ import { useRecoilValue } from 'recoil';
import { useSortDropdown } from '@/object-record/object-sort-dropdown/hooks/useSortDropdown';
import { Sort } from '@/object-record/object-sort-dropdown/types/Sort';
import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates';
import { isNonNullable } from '~/utils/isNonNullable';
type ViewBarSortEffectProps = {
sortDropdownId: string;
@ -25,10 +26,10 @@ export const ViewBarSortEffect = ({
});
useEffect(() => {
if (availableSortDefinitions) {
if (isNonNullable(availableSortDefinitions)) {
setAvailableSortDefinitions(availableSortDefinitions);
}
if (onSortSelect) {
if (isNonNullable(onSortSelect)) {
setOnSortSelect(() => onSortSelect);
}
}, [