admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354)

Browse Source 
* ESLint rule: only take explicit boolean predicates in if statements

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix frontend linter errors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix jest

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

* Fix lint on new code

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
This commit is contained in:
gitstart-app[bot]
2024-03-09 10:48:19 +01:00
committed by GitHub
parent 40bea0d95e
commit 17511be0cf
164 changed files with 655 additions and 367 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-front/src/pages/auth/ChooseYourPlan.tsx
View File

@ -1,5 +1,6 @@
import React, { useState } from 'react';
import styled from '@emotion/styled';
import { isNonEmptyString, isNumber } from '@sniptt/guards';
import { useRecoilValue } from 'recoil';
import { SubTitle } from '@/auth/components/SubTitle.tsx';
@ -17,6 +18,7 @@ import {
useCheckoutSessionMutation,
useGetProductPricesQuery,
} from '~/generated/graphql.tsx';
import { isNonNullable } from '~/utils/isNonNullable';
const StyledChoosePlanContainer = styled.div`
display: flex;
@ -57,7 +59,7 @@ export const ChooseYourPlan = () => {
const handlePlanChange = (type?: string) => {
return () => {
if (type && planSelected !== type) {
if (isNonEmptyString(type) && planSelected !== type) {
setPlanSelected(type);
}
};
@ -73,7 +75,13 @@ export const ChooseYourPlan = () => {
const monthPrice = prices.filter(
(price) => price.recurringInterval === 'month',
)?.[0];
if (monthPrice && monthPrice.unitAmount && price.unitAmount) {
if (
isNonNullable(monthPrice) &&
isNumber(monthPrice.unitAmount) &&
monthPrice.unitAmount > 0 &&
isNumber(price.unitAmount) &&
price.unitAmount > 0
) {
return `Save $${(12 * monthPrice.unitAmount - price.unitAmount) / 100}`;
}
return 'Cancel anytime';

3
packages/twenty-front/src/pages/auth/CreateWorkspace.tsx
View File

@ -21,6 +21,7 @@ import { MainButton } from '@/ui/input/button/components/MainButton';
import { TextInput } from '@/ui/input/components/TextInput';
import { GET_CURRENT_USER } from '@/users/graphql/queries/getCurrentUser';
import { useActivateWorkspaceMutation } from '~/generated/graphql';
import { isNonNullable } from '~/utils/isNonNullable';
const StyledContentContainer = styled.div`
width: 100%;
@ -81,7 +82,7 @@ export const CreateWorkspace = () => {
include: [FIND_MANY_OBJECT_METADATA_ITEMS],
});
if (result.errors) {
if (isNonNullable(result.errors)) {
throw result.errors ?? new Error('Unknown error');
}

3
packages/twenty-front/src/pages/auth/PasswordReset.tsx
View File

@ -5,6 +5,7 @@ import { useNavigate, useParams } from 'react-router-dom';
import { useTheme } from '@emotion/react';
import styled from '@emotion/styled';
import { zodResolver } from '@hookform/resolvers/zod';
import { isNonEmptyString } from '@sniptt/guards';
import { motion } from 'framer-motion';
import { z } from 'zod';
@ -112,7 +113,7 @@ export const PasswordReset = () => {
}
},
onCompleted: (data) => {
if (data?.validatePasswordResetToken?.email) {
if (isNonEmptyString(data?.validatePasswordResetToken?.email)) {
setEmail(data.validatePasswordResetToken.email);
}
},