From 1794b3a61116cf100ebdf2e59869fcca11f120fe Mon Sep 17 00:00:00 2001
From: martmull <martmull@hotmail.fr>
Date: Fri, 11 Apr 2025 14:40:00 +0200
Subject: [PATCH] Remove build lambda at creation (#11531)

Remove useless build call (done at first execution)
---
 .../drivers/interfaces/serverless-driver.interface.ts         | 1 -
 .../engine/core-modules/serverless/drivers/lambda.driver.ts   | 2 +-
 .../engine/core-modules/serverless/drivers/local.driver.ts    | 2 +-
 .../src/engine/core-modules/serverless/serverless.service.ts  | 4 ----
 .../serverless-function/serverless-function.service.ts        | 2 --
 5 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/packages/twenty-server/src/engine/core-modules/serverless/drivers/interfaces/serverless-driver.interface.ts b/packages/twenty-server/src/engine/core-modules/serverless/drivers/interfaces/serverless-driver.interface.ts
index 8521c62bc..c98db1327 100644
--- a/packages/twenty-server/src/engine/core-modules/serverless/drivers/interfaces/serverless-driver.interface.ts
+++ b/packages/twenty-server/src/engine/core-modules/serverless/drivers/interfaces/serverless-driver.interface.ts
@@ -17,7 +17,6 @@ export type ServerlessExecuteResult = {
 
 export interface ServerlessDriver {
   delete(serverlessFunction: ServerlessFunctionEntity): Promise<void>;
-  build(serverlessFunction: ServerlessFunctionEntity): Promise<void>;
   execute(
     serverlessFunction: ServerlessFunctionEntity,
     payload: object,
diff --git a/packages/twenty-server/src/engine/core-modules/serverless/drivers/lambda.driver.ts b/packages/twenty-server/src/engine/core-modules/serverless/drivers/lambda.driver.ts
index b8273378f..fa62c3ef2 100644
--- a/packages/twenty-server/src/engine/core-modules/serverless/drivers/lambda.driver.ts
+++ b/packages/twenty-server/src/engine/core-modules/serverless/drivers/lambda.driver.ts
@@ -217,7 +217,7 @@ export class LambdaDriver implements ServerlessDriver {
     }
   }
 
-  async build(serverlessFunction: ServerlessFunctionEntity) {
+  private async build(serverlessFunction: ServerlessFunctionEntity) {
     const lambdaExecutor = await this.getLambdaExecutor(serverlessFunction);
 
     if (isDefined(lambdaExecutor)) {
diff --git a/packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts b/packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts
index d3b470948..0011da1ce 100644
--- a/packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts
+++ b/packages/twenty-server/src/engine/core-modules/serverless/drivers/local.driver.ts
@@ -48,7 +48,7 @@ export class LocalDriver implements ServerlessDriver {
 
   async delete() {}
 
-  async build(serverlessFunction: ServerlessFunctionEntity) {
+  private async build(serverlessFunction: ServerlessFunctionEntity) {
     await this.createLayerIfNotExists(serverlessFunction.layerVersion);
   }
 
diff --git a/packages/twenty-server/src/engine/core-modules/serverless/serverless.service.ts b/packages/twenty-server/src/engine/core-modules/serverless/serverless.service.ts
index f5dfc348d..3f6b8c7e7 100644
--- a/packages/twenty-server/src/engine/core-modules/serverless/serverless.service.ts
+++ b/packages/twenty-server/src/engine/core-modules/serverless/serverless.service.ts
@@ -16,10 +16,6 @@ export class ServerlessService implements ServerlessDriver {
     return this.driver.delete(serverlessFunction);
   }
 
-  async build(serverlessFunction: ServerlessFunctionEntity): Promise<void> {
-    return this.driver.build(serverlessFunction);
-  }
-
   async execute(
     serverlessFunction: ServerlessFunctionEntity,
     payload: object,
diff --git a/packages/twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts b/packages/twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts
index 682cc0dde..058bd2277 100644
--- a/packages/twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts
@@ -347,8 +347,6 @@ export class ServerlessFunctionService {
       });
     }
 
-    await this.serverlessService.build(createdServerlessFunction);
-
     return this.serverlessFunctionRepository.findOneBy({
       id: createdServerlessFunction.id,
     });