refactor(custom-domain): simplify record mapping logic (#10685)

Refactored the mapping logic in custom-domain.service to improve
readability and ensure proper handling of undefined records. This change
introduces an early return for nullish records and maintains existing
validation behavior.

packages/twenty-server/src/engine/core-modules/domain-manager/services/custom-domain.service.spec.ts

@@ -123,6 +123,36 @@ describe('CustomDomainService', () => {
         hostname: customDomain,
       });
     });
+    it('should return even if no record found', async () => {
+      const customDomain = 'example.com';
+      const mockResult = {
+        id: 'custom-id',
+        hostname: customDomain,
+        ownership_verification: undefined,
+        verification_errors: [],
+      };
+      const cloudflareMock = {
+        customHostnames: {
+          list: jest.fn().mockResolvedValueOnce({ result: [mockResult] }),
+        },
+      };
+
+      jest.spyOn(environmentService, 'get').mockReturnValue('test-zone-id');
+
+      jest
+        .spyOn(domainManagerService, 'getFrontUrl')
+        .mockReturnValue(new URL('https://front.domain'));
+      (customDomainService as any).cloudflareClient = cloudflareMock;
+
+      const result =
+        await customDomainService.getCustomDomainDetails(customDomain);
+
+      expect(result).toEqual({
+        id: 'custom-id',
+        customDomain: customDomain,
+        records: expect.any(Array),
+      });
+    });
 
     it('should return domain details if a single result is found', async () => {
       const customDomain = 'example.com';

packages/twenty-server/src/engine/core-modules/domain-manager/services/custom-domain.service.ts

@@ -79,8 +79,9 @@ export class CustomDomainService {
           response.result[0].ownership_verification,
           ...(response.result[0].ssl?.validation_records ?? []),
         ]
-          .map<CustomDomainValidRecords['records'][0] | undefined>(
+          .map<CustomDomainValidRecords['records'][0] | undefined>((record) => {
-            (record: Record<string, string>) => {
+            if (!record) return;
+
             if (
               'txt_name' in record &&
               'txt_value' in record &&
@@ -114,8 +115,7 @@ export class CustomDomainService {
                 value: record.value,
               };
             }
-            },
+          })
-          )
           .filter(isDefined)
           .concat([
             {