admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Side panel tablist fix (#10904)

Browse Source 
followup #10832
whats wrong? -- in "before" screen grabs, the light bottom border
doesn't go all the way!

fix -- removed the redundant div :)

(╯°□°）╯︵ ┻━┻

before:
<img width="608" alt="Screenshot 2025-03-14 at 22 26 26"
src="https://github.com/user-attachments/assets/4fff92f7-5adc-4816-95dc-7b78ad08cd1c"
/>
<img width="605" alt="Screenshot 2025-03-14 at 22 26 20"
src="https://github.com/user-attachments/assets/e7a796a3-d5ff-4366-bd45-afbe3a219ee5"
/>
after:
<img width="610" alt="Screenshot 2025-03-14 at 22 24 33"
src="https://github.com/user-attachments/assets/c6f744b8-ec8b-4549-a1bb-db1a9fd1fafe"
/>
<img width="603" alt="Screenshot 2025-03-14 at 22 24 24"
src="https://github.com/user-attachments/assets/4758a591-3375-4387-a115-c74d534decb6"
/>
This commit is contained in:
nitin
2025-03-14 23:02:46 +05:30
committed by GitHub
parent f44f42e9a0
commit 1bc30e9b21
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageSubContainer.tsx
View File

@ -26,10 +26,6 @@ const StyledShowPageRightContainer = styled.div<{ isMobile: boolean }>`
overflow: auto; overflow: auto;
`; `;
const StyledTabListContainer = styled.div<{ shouldDisplay: boolean }>`
display: ${({ shouldDisplay }) => (shouldDisplay ? 'flex' : 'none')};
`;
const StyledTabList = styled(TabList)` const StyledTabList = styled(TabList)`
padding-left: ${({ theme }) => theme.spacing(2)}; padding-left: ${({ theme }) => theme.spacing(2)};
`; `;
@ -124,7 +120,7 @@ export const ShowPageSubContainer = ({
</ShowPageLeftContainer> </ShowPageLeftContainer>
)} )}
<StyledShowPageRightContainer isMobile={isMobile}> <StyledShowPageRightContainer isMobile={isMobile}>
<StyledTabListContainer shouldDisplay={visibleTabs.length > 1}> {visibleTabs.length > 1 && (
<StyledTabList <StyledTabList
behaveAsLinks={!isInRightDrawer} behaveAsLinks={!isInRightDrawer}
loading={loading || isNewViewableRecordLoading} loading={loading || isNewViewableRecordLoading}
@ -132,7 +128,7 @@ export const ShowPageSubContainer = ({
tabs={tabs} tabs={tabs}
isInRightDrawer={isInRightDrawer} isInRightDrawer={isInRightDrawer}
/> />
</StyledTabListContainer> )}
{(isMobile || isInRightDrawer) && summaryCard} {(isMobile || isInRightDrawer) && summaryCard}
<StyledContentContainer isInRightDrawer={isInRightDrawer}> <StyledContentContainer isInRightDrawer={isInRightDrawer}>
{renderActiveTabContent()} {renderActiveTabContent()}