Fix twenty-front performances (#6744)
I have investigated the performance of our frontend vite build: `npx nx run twenty:start` of `npx nx run twenty:build` RAM usage: - 160Mb: vite serve - background typescript checker: 2.5GB - background eslint checker: 3.5GB I'm introducing two environment variables in FE .env to disable these checkers on lower configuration (and to disable them from CD build): ``` # VITE_DISABLE_TYPESCRIPT_CHECKER=true # VITE_DISABLE_ESLINT_CHECKER=true ```
This commit is contained in:
@ -15,7 +15,12 @@ export default defineConfig(({ command, mode }) => {
|
||||
/*
|
||||
Using explicit env variables, there is no need to expose all of them (security).
|
||||
*/
|
||||
const { REACT_APP_SERVER_BASE_URL, VITE_BUILD_SOURCEMAP } = env;
|
||||
const {
|
||||
REACT_APP_SERVER_BASE_URL,
|
||||
VITE_BUILD_SOURCEMAP,
|
||||
VITE_DISABLE_TYPESCRIPT_CHECKER,
|
||||
VITE_DISABLE_ESLINT_CHECKER,
|
||||
} = env;
|
||||
|
||||
const isBuildCommand = command === 'build';
|
||||
|
||||
@ -24,13 +29,16 @@ export default defineConfig(({ command, mode }) => {
|
||||
: path.resolve(__dirname, './tsconfig.dev.json');
|
||||
|
||||
const checkers: Checkers = {
|
||||
typescript: {
|
||||
tsconfigPath: tsConfigPath,
|
||||
},
|
||||
overlay: false,
|
||||
};
|
||||
|
||||
if (!isBuildCommand) {
|
||||
if (VITE_DISABLE_TYPESCRIPT_CHECKER !== 'true') {
|
||||
checkers['typescript'] = {
|
||||
tsconfigPath: tsConfigPath,
|
||||
};
|
||||
}
|
||||
|
||||
if (VITE_DISABLE_ESLINT_CHECKER !== 'true') {
|
||||
checkers['eslint'] = {
|
||||
lintCommand:
|
||||
'eslint . --report-unused-disable-directives --max-warnings 0 --config .eslintrc.cjs',
|
||||
|
||||
Reference in New Issue
Block a user