From 1f9c340bc64883d06d76f956cc9ef59d8c8da90f Mon Sep 17 00:00:00 2001 From: Charles Bochet Date: Mon, 27 May 2024 11:50:19 +0200 Subject: [PATCH] Fix record board broken position (#5588) Position were not queries anymore while populating kanban board, breaking the drag and drop feature --- .../utils/{hasPositionColumn.ts => hasPositionField.ts} | 0 .../object-sort-dropdown/utils/turnSortsIntoOrderBy.ts | 2 +- .../record-index/hooks/useRecordBoardRecordGqlFields.ts | 2 ++ 3 files changed, 3 insertions(+), 1 deletion(-) rename packages/twenty-front/src/modules/object-metadata/utils/{hasPositionColumn.ts => hasPositionField.ts} (100%) diff --git a/packages/twenty-front/src/modules/object-metadata/utils/hasPositionColumn.ts b/packages/twenty-front/src/modules/object-metadata/utils/hasPositionField.ts similarity index 100% rename from packages/twenty-front/src/modules/object-metadata/utils/hasPositionColumn.ts rename to packages/twenty-front/src/modules/object-metadata/utils/hasPositionField.ts diff --git a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts index fa6767d1e..b30f24570 100644 --- a/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts +++ b/packages/twenty-front/src/modules/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy.ts @@ -1,6 +1,6 @@ import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; import { OrderBy } from '@/object-metadata/types/OrderBy'; -import { hasPositionField } from '@/object-metadata/utils/hasPositionColumn'; +import { hasPositionField } from '@/object-metadata/utils/hasPositionField'; import { RecordGqlOperationOrderBy } from '@/object-record/graphql/types/RecordGqlOperationOrderBy'; import { Field } from '~/generated/graphql'; import { mapArrayToObject } from '~/utils/array/mapArrayToObject'; diff --git a/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordBoardRecordGqlFields.ts b/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordBoardRecordGqlFields.ts index d0b423dd3..b271e6cbb 100644 --- a/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordBoardRecordGqlFields.ts +++ b/packages/twenty-front/src/modules/object-record/record-index/hooks/useRecordBoardRecordGqlFields.ts @@ -2,6 +2,7 @@ import { useRecoilValue } from 'recoil'; import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; import { getObjectMetadataIdentifierFields } from '@/object-metadata/utils/getObjectMetadataIdentifierFields'; +import { hasPositionField } from '@/object-metadata/utils/hasPositionField'; import { useRecordBoardStates } from '@/object-record/record-board/hooks/internal/useRecordBoardStates'; import { isDefined } from '~/utils/isDefined'; @@ -41,6 +42,7 @@ export const useRecordBoardRecordGqlFields = ({ true, ]), ), + ...(hasPositionField(objectMetadataItem) ? { position: true } : undefined), ...identifierQueryFields, };