From 203d4fc84fab8814e7a034e9c41d8c40d568a8a3 Mon Sep 17 00:00:00 2001
From: Weiko <corentin@twenty.com>
Date: Tue, 20 May 2025 11:38:16 +0200
Subject: [PATCH] Fix: Deleting an opportunity from the relation detail section
 deletes a person (#12137)

Fixes https://github.com/twentyhq/twenty/issues/12131

All instances of RecordDetailRelationRecordsListItem are sharing the
same DELETE_RELATION_MODAL_ID, this PR makes the modal ID unique for
each item.
---
 .../components/RecordDetailRelationRecordsListItem.tsx     | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx b/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
index ded78d000..7fbea02e3 100644
--- a/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx
@@ -87,7 +87,8 @@ const StyledClickableZone = styled.div`
 
 const MotionIconChevronDown = motion.create(IconChevronDown);
 
-const DELETE_RELATION_MODAL_ID = 'delete-relation-modal';
+const getDeleteRelationModalId = (recordId: string) =>
+  `delete-relation-modal-${recordId}`;
 
 type RecordDetailRelationRecordsListItemProps = {
   isExpanded: boolean;
@@ -175,7 +176,7 @@ export const RecordDetailRelationRecordsListItem = ({
 
   const handleDelete = async () => {
     closeDropdown();
-    openModal(DELETE_RELATION_MODAL_ID);
+    openModal(getDeleteRelationModalId(relationRecord.id));
   };
 
   const handleConfirmDelete = async () => {
@@ -305,7 +306,7 @@ export const RecordDetailRelationRecordsListItem = ({
       </AnimatedEaseInOut>
       {createPortal(
         <ConfirmationModal
-          modalId={DELETE_RELATION_MODAL_ID}
+          modalId={getDeleteRelationModalId(relationRecord.id)}
           title={`Delete Related ${relationObjectTypeName}`}
           subtitle={
             <>