Fix metadata exception handler #2 (#3357)

packages/twenty-server/src/metadata/field-metadata/field-metadata.resolver.ts

@@ -19,14 +19,10 @@ export class FieldMetadataResolver {
     @Args('input') input: CreateOneFieldMetadataInput,
     @AuthWorkspace() { id: workspaceId }: Workspace,
   ) {
-    try {
-      return this.fieldMetadataService.createOne({
-        ...input.field,
-        workspaceId,
-      });
-    } catch (error) {
-      console.log(error);
-    }
+    return this.fieldMetadataService.createOne({
+      ...input.field,
+      workspaceId,
+    });
   }
 
   @Mutation(() => FieldMetadataDTO)

packages/twenty-server/src/metadata/field-metadata/field-metadata.service.ts

@@ -56,7 +56,7 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
       );
 
     if (!objectMetadata) {
-      throw new Error('Object does not exist');
+      throw new NotFoundException('Object does not exist');
     }
 
     const fieldAlreadyExists = await this.fieldMetadataRepository.findOne({

packages/twenty-server/src/metadata/metadata.module-factory.ts

@@ -24,9 +24,9 @@ export const metadataModuleFactory = async (
           error.originalError,
           exceptionHandlerService,
         );
-      } else {
-        return maskError(error, message, isDev);
       }
+
+      return maskError(error, message, isDev);
     },
   },
 });

packages/twenty-server/src/metadata/metadata.module.ts

@@ -6,6 +6,7 @@ import { YogaDriverConfig, YogaDriver } from '@graphql-yoga/nestjs';
 import { WorkspaceMigrationRunnerModule } from 'src/workspace/workspace-migration-runner/workspace-migration-runner.module';
 import { WorkspaceMigrationModule } from 'src/metadata/workspace-migration/workspace-migration.module';
 import { metadataModuleFactory } from 'src/metadata/metadata.module-factory';
+import { ExceptionHandlerService } from 'src/integrations/exception-handler/exception-handler.service';
 
 import { DataSourceModule } from './data-source/data-source.module';
 import { FieldMetadataModule } from './field-metadata/field-metadata.module';
@@ -15,7 +16,7 @@ import { RelationMetadataModule } from './relation-metadata/relation-metadata.mo
   imports: [
     GraphQLModule.forRootAsync<YogaDriverConfig>({
       driver: YogaDriver,
-      imports: [],
+      inject: [ExceptionHandlerService],
       useFactory: metadataModuleFactory,
     }),
     DataSourceModule,

packages/twenty-server/src/metadata/object-metadata/object-metadata.service.ts

@@ -1,4 +1,4 @@
-import { Injectable } from '@nestjs/common';
+import { BadRequestException, Injectable } from '@nestjs/common';
 import { InjectRepository } from '@nestjs/typeorm';
 
 import { FindManyOptions, FindOneOptions, Repository } from 'typeorm';
@@ -59,7 +59,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
       objectMetadataInput.nameSingular.toLowerCase() ===
       objectMetadataInput.namePlural.toLowerCase()
     ) {
-      throw new Error(
+      throw new BadRequestException(
         'The singular and plural name cannot be the same for an object',
       );
     }