admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix filter with empty field (#11787)

Browse Source 
Attempt to fix https://github.com/twentyhq/core-team-issues/issues/899

Could not reproduce but that's the only place in the code where I found
that we build filters as such, with values for "in" being equal to
select options and not recordIds, as it seems to be the case from the
sentries (ex:
<img width="174" alt="Capture d’écran 2025-04-29 à 11 13 56"
src="https://github.com/user-attachments/assets/a0b62de1-fe23-4394-9f86-a205ee32b56c"
/>
)
This commit is contained in:
Marie
2025-04-29 11:56:14 +02:00
committed by GitHub
parent fda793ced2
commit 2482271545
1 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
packages/twenty-front/src/modules/object-record/record-index/hooks/useLoadRecordIndexBoardColumn.ts
View File

@ -15,6 +15,7 @@ import { useRecordBoardRecordGqlFields } from '@/object-record/record-index/hook
import { currentRecordSortsComponentState } from '@/object-record/record-sort/states/currentRecordSortsComponentState'; import { currentRecordSortsComponentState } from '@/object-record/record-sort/states/currentRecordSortsComponentState';
import { useUpsertRecordsInStore } from '@/object-record/record-store/hooks/useUpsertRecordsInStore'; import { useUpsertRecordsInStore } from '@/object-record/record-store/hooks/useUpsertRecordsInStore';
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
import { isNonEmptyString } from '@sniptt/guards';
import { isDefined } from 'twenty-shared/utils'; import { isDefined } from 'twenty-shared/utils';
type UseLoadRecordIndexBoardProps = { type UseLoadRecordIndexBoardProps = {
@ -68,17 +69,33 @@ export const useLoadRecordIndexBoardColumn = ({
recordBoardId, recordBoardId,
}); });
const recordIndexKanbanFieldMetadataItem = objectMetadataItem.fields.find( let recordIndexKanbanFieldMetadataFilter: { [x: string]: any } = {};
(field) => field.id === boardFieldMetadataId,
); if (isDefined(boardFieldMetadataId)) {
const recordIndexKanbanFieldMetadataItem = objectMetadataItem.fields.find(
(field) => field.id === boardFieldMetadataId,
);
if (!isDefined(recordIndexKanbanFieldMetadataItem)) {
throw new Error('Record index kanban field metadata item not found');
}
if (!isNonEmptyString(recordIndexKanbanFieldMetadataItem?.name ?? '')) {
throw new Error('Record index kanban field metadata item name not found');
}
recordIndexKanbanFieldMetadataFilter = {
[recordIndexKanbanFieldMetadataItem.name]: isDefined(
recordGroupDefinition?.value,
)
? { in: [recordGroupDefinition.value] }
: { is: 'NULL' },
};
}
const filter = { const filter = {
...requestFilters, ...requestFilters,
[recordIndexKanbanFieldMetadataItem?.name ?? '']: isDefined( ...recordIndexKanbanFieldMetadataFilter,
recordGroupDefinition?.value,
)
? { in: [recordGroupDefinition?.value] }
: { is: 'NULL' },
}; };
const { const {