admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix(view): Show Kanban View Creation (#5985)

Browse Source 
# This PR
- Revise my previous work (PR #5969)
Because it would break the current logic and cause unexpected behavior.
(Issue #5979)
- Solve (Issue #5915) with another way

@lucasbordeau  What do you think about my current approach?
@JarWarren Please check it out—I'd love to get your feedback too!

---------

Co-authored-by: Achsan <achsanh@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
This commit is contained in:
Us3r-gitHub
2024-06-24 21:05:40 +07:00
committed by GitHub
parent 57bbd7c129
commit 24c31f9b39
3 changed files with 16 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/twenty-front/src/modules/views/view-picker/components/ViewPickerDropdown.tsx
View File

@ -1,6 +1,6 @@
import { useTheme } from '@emotion/react';
import styled from '@emotion/styled';
import { useRecoilValue, useSetRecoilState } from 'recoil';
import { useRecoilValue } from 'recoil';
import {
IconChevronDown,
IconList,
@ -19,7 +19,6 @@ import { ViewPickerListContent } from '@/views/view-picker/components/ViewPicker
import { VIEW_PICKER_DROPDOWN_ID } from '@/views/view-picker/constants/ViewPickerDropdownId';
import { useViewPickerMode } from '@/views/view-picker/hooks/useViewPickerMode';
import { useViewPickerPersistView } from '@/views/view-picker/hooks/useViewPickerPersistView';
import { useViewPickerStates } from '@/views/view-picker/hooks/useViewPickerStates';
import { isDefined } from '~/utils/isDefined';
import { useViewStates } from '../../hooks/internal/useViewStates';
@ -53,8 +52,6 @@ export const ViewPickerDropdown = () => {
const { entityCountInCurrentViewState } = useViewStates();
const { viewPickerIsDirtyState } = useViewPickerStates();
const { currentViewWithCombinedFiltersAndSorts } = useGetCurrentView();
const { handleUpdate } = useViewPickerPersistView();
@ -63,8 +60,6 @@ export const ViewPickerDropdown = () => {
entityCountInCurrentViewState,
);
const setViewPickerIsDirty = useSetRecoilState(viewPickerIsDirtyState);
const { isDropdownOpen: isViewsListDropdownOpen } = useDropdown(
VIEW_PICKER_DROPDOWN_ID,
);
@ -75,7 +70,6 @@ export const ViewPickerDropdown = () => {
const CurrentViewIcon = getIcon(currentViewWithCombinedFiltersAndSorts?.icon);
const handleClickOutside = async () => {
setViewPickerIsDirty(false);
if (isViewsListDropdownOpen && viewPickerMode === 'edit') {
await handleUpdate();
}