admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove form feature flag (#11369)

Browse Source 
As title. Workflows are still in the lab and forms are starting to be
usable
This commit is contained in:
Thomas Trompette
2025-04-03 10:38:19 +02:00
committed by GitHub
parent 1240d39f56
commit 256a5c1a2b
5 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/generated-metadata/graphql.ts
View File

@ -566,13 +566,13 @@ export enum FeatureFlagKey {
IsCustomDomainEnabled = 'IsCustomDomainEnabled', IsCustomDomainEnabled = 'IsCustomDomainEnabled',
IsEventObjectEnabled = 'IsEventObjectEnabled', IsEventObjectEnabled = 'IsEventObjectEnabled',
IsJsonFilterEnabled = 'IsJsonFilterEnabled', IsJsonFilterEnabled = 'IsJsonFilterEnabled',
IsMeteredProductBillingEnabled = 'IsMeteredProductBillingEnabled',
IsNewRelationEnabled = 'IsNewRelationEnabled', IsNewRelationEnabled = 'IsNewRelationEnabled',
IsPermissionsV2Enabled = 'IsPermissionsV2Enabled', IsPermissionsV2Enabled = 'IsPermissionsV2Enabled',
IsPostgreSQLIntegrationEnabled = 'IsPostgreSQLIntegrationEnabled', IsPostgreSQLIntegrationEnabled = 'IsPostgreSQLIntegrationEnabled',
IsStripeIntegrationEnabled = 'IsStripeIntegrationEnabled', IsStripeIntegrationEnabled = 'IsStripeIntegrationEnabled',
IsUniqueIndexesEnabled = 'IsUniqueIndexesEnabled', IsUniqueIndexesEnabled = 'IsUniqueIndexesEnabled',
IsWorkflowEnabled = 'IsWorkflowEnabled', IsWorkflowEnabled = 'IsWorkflowEnabled'
IsWorkflowFormActionEnabled = 'IsWorkflowFormActionEnabled'
} }
export type Field = { export type Field = {

4
packages/twenty-front/src/generated/graphql.tsx
View File

@ -497,13 +497,13 @@ export enum FeatureFlagKey {
IsCustomDomainEnabled = 'IsCustomDomainEnabled', IsCustomDomainEnabled = 'IsCustomDomainEnabled',
IsEventObjectEnabled = 'IsEventObjectEnabled', IsEventObjectEnabled = 'IsEventObjectEnabled',
IsJsonFilterEnabled = 'IsJsonFilterEnabled', IsJsonFilterEnabled = 'IsJsonFilterEnabled',
IsMeteredProductBillingEnabled = 'IsMeteredProductBillingEnabled',
IsNewRelationEnabled = 'IsNewRelationEnabled', IsNewRelationEnabled = 'IsNewRelationEnabled',
IsPermissionsV2Enabled = 'IsPermissionsV2Enabled', IsPermissionsV2Enabled = 'IsPermissionsV2Enabled',
IsPostgreSQLIntegrationEnabled = 'IsPostgreSQLIntegrationEnabled', IsPostgreSQLIntegrationEnabled = 'IsPostgreSQLIntegrationEnabled',
IsStripeIntegrationEnabled = 'IsStripeIntegrationEnabled', IsStripeIntegrationEnabled = 'IsStripeIntegrationEnabled',
IsUniqueIndexesEnabled = 'IsUniqueIndexesEnabled', IsUniqueIndexesEnabled = 'IsUniqueIndexesEnabled',
IsWorkflowEnabled = 'IsWorkflowEnabled', IsWorkflowEnabled = 'IsWorkflowEnabled'
IsWorkflowFormActionEnabled = 'IsWorkflowFormActionEnabled'
} }
export type Field = { export type Field = {

9
packages/twenty-front/src/modules/command-menu/pages/workflow/action/components/CommandMenuWorkflowSelectActionContent.tsx
View File

@ -4,9 +4,7 @@ import { RightDrawerWorkflowSelectStepTitle } from '@/workflow/workflow-steps/co
import { useCreateStep } from '@/workflow/workflow-steps/hooks/useCreateStep'; import { useCreateStep } from '@/workflow/workflow-steps/hooks/useCreateStep';
import { OTHER_ACTIONS } from '@/workflow/workflow-steps/workflow-actions/constants/OtherActions'; import { OTHER_ACTIONS } from '@/workflow/workflow-steps/workflow-actions/constants/OtherActions';
import { RECORD_ACTIONS } from '@/workflow/workflow-steps/workflow-actions/constants/RecordActions'; import { RECORD_ACTIONS } from '@/workflow/workflow-steps/workflow-actions/constants/RecordActions';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { MenuItemCommand, useIcons } from 'twenty-ui'; import { MenuItemCommand, useIcons } from 'twenty-ui';
import { FeatureFlagKey } from '~/generated-metadata/graphql';
export const CommandMenuWorkflowSelectActionContent = ({ export const CommandMenuWorkflowSelectActionContent = ({
workflow, workflow,
@ -17,9 +15,6 @@ export const CommandMenuWorkflowSelectActionContent = ({
const { createStep } = useCreateStep({ const { createStep } = useCreateStep({
workflow, workflow,
}); });
const isWorkflowFormActionEnabled = useIsFeatureEnabled(
FeatureFlagKey.IsWorkflowFormActionEnabled,
);
return ( return (
<RightDrawerStepListContainer> <RightDrawerStepListContainer>
@ -37,9 +32,7 @@ export const CommandMenuWorkflowSelectActionContent = ({
<RightDrawerWorkflowSelectStepTitle> <RightDrawerWorkflowSelectStepTitle>
Other Other
</RightDrawerWorkflowSelectStepTitle> </RightDrawerWorkflowSelectStepTitle>
{OTHER_ACTIONS.filter( {OTHER_ACTIONS.map((action) => (
(action) => isWorkflowFormActionEnabled || action.type !== 'FORM',
).map((action) => (
<MenuItemCommand <MenuItemCommand
key={action.type} key={action.type}
LeftIcon={getIcon(action.icon)} LeftIcon={getIcon(action.icon)}

5
packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts
View File

@ -65,11 +65,6 @@ export const seedFeatureFlags = async (
workspaceId: workspaceId, workspaceId: workspaceId,
value: false, value: false,
}, },
{
key: FeatureFlagKey.IsWorkflowFormActionEnabled,
workspaceId: workspaceId,
value: true,
},
]) ])
.execute(); .execute();
}; };

1
packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts
View File

@ -11,7 +11,6 @@ export enum FeatureFlagKey {
IsCustomDomainEnabled = 'IS_CUSTOM_DOMAIN_ENABLED', IsCustomDomainEnabled = 'IS_CUSTOM_DOMAIN_ENABLED',
IsApprovedAccessDomainsEnabled = 'IS_APPROVED_ACCESS_DOMAINS_ENABLED', IsApprovedAccessDomainsEnabled = 'IS_APPROVED_ACCESS_DOMAINS_ENABLED',
IsNewRelationEnabled = 'IS_NEW_RELATION_ENABLED', IsNewRelationEnabled = 'IS_NEW_RELATION_ENABLED',
IsWorkflowFormActionEnabled = 'IS_WORKFLOW_FORM_ACTION_ENABLED',
IsPermissionsV2Enabled = 'IS_PERMISSIONS_V2_ENABLED', IsPermissionsV2Enabled = 'IS_PERMISSIONS_V2_ENABLED',
IsMeteredProductBillingEnabled = 'IS_METERED_PRODUCT_BILLING_ENABLED', IsMeteredProductBillingEnabled = 'IS_METERED_PRODUCT_BILLING_ENABLED',
} }