Fix Boolean field for hotkey (#2067)
* Fix Boolean field for hotkey * make via hook * typo --------- Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
This commit is contained in:
@ -1,6 +1,7 @@
|
|||||||
import { PropsWithChildren, useEffect, useRef } from 'react';
|
import { PropsWithChildren, useEffect, useRef } from 'react';
|
||||||
|
|
||||||
import { useIsFieldInputOnly } from '@/ui/data/field/hooks/useIsFieldInputOnly';
|
import { useIsFieldInputOnly } from '@/ui/data/field/hooks/useIsFieldInputOnly';
|
||||||
|
import { useToggleEditOnlyInput } from '@/ui/data/field/hooks/useToggleEditOnlyInput';
|
||||||
import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys';
|
import { useScopedHotkeys } from '@/ui/utilities/hotkey/hooks/useScopedHotkeys';
|
||||||
import { isNonTextWritingKey } from '@/ui/utilities/hotkey/utils/isNonTextWritingKey';
|
import { isNonTextWritingKey } from '@/ui/utilities/hotkey/utils/isNonTextWritingKey';
|
||||||
|
|
||||||
@ -17,7 +18,7 @@ export const TableCellSoftFocusMode = ({
|
|||||||
const { openTableCell } = useTableCell();
|
const { openTableCell } = useTableCell();
|
||||||
|
|
||||||
const isFieldInputOnly = useIsFieldInputOnly();
|
const isFieldInputOnly = useIsFieldInputOnly();
|
||||||
|
const toggleEditOnlyInput = useToggleEditOnlyInput();
|
||||||
const scrollRef = useRef<HTMLDivElement>(null);
|
const scrollRef = useRef<HTMLDivElement>(null);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@ -27,34 +28,36 @@ export const TableCellSoftFocusMode = ({
|
|||||||
useScopedHotkeys(
|
useScopedHotkeys(
|
||||||
'enter',
|
'enter',
|
||||||
() => {
|
() => {
|
||||||
openTableCell();
|
if (!isFieldInputOnly) {
|
||||||
|
openTableCell();
|
||||||
|
} else {
|
||||||
|
toggleEditOnlyInput();
|
||||||
|
}
|
||||||
},
|
},
|
||||||
TableHotkeyScope.TableSoftFocus,
|
TableHotkeyScope.TableSoftFocus,
|
||||||
[openTableCell],
|
[openTableCell],
|
||||||
{
|
|
||||||
enabled: !isFieldInputOnly,
|
|
||||||
},
|
|
||||||
);
|
);
|
||||||
|
|
||||||
useScopedHotkeys(
|
useScopedHotkeys(
|
||||||
'*',
|
'*',
|
||||||
(keyboardEvent) => {
|
(keyboardEvent) => {
|
||||||
const isWritingText =
|
if (!isFieldInputOnly) {
|
||||||
!isNonTextWritingKey(keyboardEvent.key) &&
|
const isWritingText =
|
||||||
!keyboardEvent.ctrlKey &&
|
!isNonTextWritingKey(keyboardEvent.key) &&
|
||||||
!keyboardEvent.metaKey;
|
!keyboardEvent.ctrlKey &&
|
||||||
|
!keyboardEvent.metaKey;
|
||||||
|
|
||||||
if (!isWritingText) {
|
if (!isWritingText) {
|
||||||
return;
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
openTableCell();
|
||||||
}
|
}
|
||||||
|
|
||||||
openTableCell();
|
|
||||||
},
|
},
|
||||||
TableHotkeyScope.TableSoftFocus,
|
TableHotkeyScope.TableSoftFocus,
|
||||||
[openTableCell],
|
[openTableCell],
|
||||||
{
|
{
|
||||||
preventDefault: false,
|
preventDefault: false,
|
||||||
enabled: !isFieldInputOnly,
|
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@ -0,0 +1,48 @@
|
|||||||
|
import { useContext } from 'react';
|
||||||
|
import { useRecoilCallback } from 'recoil';
|
||||||
|
|
||||||
|
import { FieldContext } from '../contexts/FieldContext';
|
||||||
|
import { entityFieldsFamilySelector } from '../states/selectors/entityFieldsFamilySelector';
|
||||||
|
import { isFieldBoolean } from '../types/guards/isFieldBoolean';
|
||||||
|
|
||||||
|
export const useToggleEditOnlyInput = () => {
|
||||||
|
const { entityId, fieldDefinition, useUpdateEntityMutation } =
|
||||||
|
useContext(FieldContext);
|
||||||
|
|
||||||
|
const [updateEntity] = useUpdateEntityMutation();
|
||||||
|
|
||||||
|
const toggleField = useRecoilCallback(
|
||||||
|
({ set, snapshot }) =>
|
||||||
|
() => {
|
||||||
|
const fieldIsBoolean = isFieldBoolean(fieldDefinition);
|
||||||
|
|
||||||
|
if (fieldIsBoolean) {
|
||||||
|
const fieldName = fieldDefinition.metadata.fieldName;
|
||||||
|
const oldValue = snapshot
|
||||||
|
.getLoadable(entityFieldsFamilySelector({ entityId, fieldName }))
|
||||||
|
.valueOrThrow();
|
||||||
|
const valueToPersist = !oldValue;
|
||||||
|
set(
|
||||||
|
entityFieldsFamilySelector({ entityId, fieldName }),
|
||||||
|
valueToPersist,
|
||||||
|
);
|
||||||
|
|
||||||
|
updateEntity({
|
||||||
|
variables: {
|
||||||
|
where: { id: entityId },
|
||||||
|
data: {
|
||||||
|
[fieldName]: valueToPersist,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
throw new Error(
|
||||||
|
`Invalid value to toggle for type : ${fieldDefinition.type}, type may not be implemented in useToggleEditOnlyInput.`,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
},
|
||||||
|
[entityId, fieldDefinition, updateEntity],
|
||||||
|
);
|
||||||
|
|
||||||
|
return toggleField;
|
||||||
|
};
|
||||||
Reference in New Issue
Block a user