admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

bugfix: remove infinite renderloop of onSortUpdate

Browse Source
This commit is contained in:
Sammy Teillet
2023-04-24 14:46:39 +02:00
parent c7dc9cf83b
commit 2acd98370d
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
front/src/components/table/table-header/TableHeader.tsx
View File

@ -3,7 +3,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import DropdownButton from './DropdownButton'; import DropdownButton from './DropdownButton';
import { IconProp } from '@fortawesome/fontawesome-svg-core'; import { IconProp } from '@fortawesome/fontawesome-svg-core';
import SortAndFilterBar, { SortType } from './SortAndFilterBar'; import SortAndFilterBar, { SortType } from './SortAndFilterBar';
import { useEffect, useState } from 'react'; import { useState } from 'react';
type OwnProps = { type OwnProps = {
viewName: string; viewName: string;
@ -53,21 +53,22 @@ function TableHeader({
const [sorts, setSorts] = useState([] as Array<SortType>); const [sorts, setSorts] = useState([] as Array<SortType>);
const onSortItemSelect = (sortId: string) => { const onSortItemSelect = (sortId: string) => {
setSorts([ const newSorts = [
{ {
label: 'Created at', label: 'Created at',
order: 'asc', order: 'asc',
id: sortId, id: sortId,
} as SortType, } as SortType,
]); ];
}; setSorts(newSorts);
const onSortItemUnSelect = (sortId: string) => { onSortsUpdate && onSortsUpdate(newSorts);
setSorts([]);
}; };
useEffect(() => { const onSortItemUnSelect = (sortId: string) => {
onSortsUpdate && onSortsUpdate(sorts); const newSorts = [] as SortType[];
}, [sorts, onSortsUpdate]); setSorts(newSorts);
onSortsUpdate && onSortsUpdate(newSorts);
};
return ( return (
<StyledContainer> <StyledContainer>