admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Prevent remote object updates (#4804)

Browse Source 
Backend: Adding a new util function that throw an error if the
objectMetadata is remote

Frontend: hiding the save button when remote

Also renaming `useObjectMetadataItemForSettings` since this hook is used
in other places than settings and is not in the settings repo. Name can
definitely be challenged!

---------

Co-authored-by: Thomas Trompette <thomast@twenty.com>
This commit is contained in:
Thomas Trompette
2024-04-04 15:47:08 +02:00
committed by GitHub
parent c5349291c8
commit 2e419091cc
16 changed files with 79 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/twenty-front/src/pages/object-record/RecordIndexPageHeader.tsx
View File

@ -1,7 +1,7 @@
import { useParams } from 'react-router-dom';
import { useRecoilValue } from 'recoil';
import { useObjectMetadataItemForSettings } from '@/object-metadata/hooks/useObjectMetadataItemForSettings';
import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilteredObjectMetadataItems';
import { recordIndexViewTypeState } from '@/object-record/record-index/states/recordIndexViewTypeState';
import { useIcons } from '@/ui/display/icon/hooks/useIcons';
import { PageAddButton } from '@/ui/layout/page/PageAddButton';
@ -20,7 +20,10 @@ export const RecordIndexPageHeader = ({
const objectNamePlural = useParams().objectNamePlural ?? '';
const { findObjectMetadataItemByNamePlural } =
useObjectMetadataItemForSettings();
useFilteredObjectMetadataItems();
const objectMetadataItem =
findObjectMetadataItemByNamePlural(objectNamePlural);
const { getIcon } = useIcons();
const Icon = getIcon(
@ -29,12 +32,13 @@ export const RecordIndexPageHeader = ({
const recordIndexViewType = useRecoilValue(recordIndexViewTypeState);
const canAddRecord =
recordIndexViewType === ViewType.Table && !objectMetadataItem?.isRemote;
return (
<PageHeader title={capitalize(objectNamePlural)} Icon={Icon}>
<PageHotkeysEffect onAddButtonClick={createRecord} />
{recordIndexViewType === ViewType.Table && (
<PageAddButton onClick={createRecord} />
)}
{canAddRecord && <PageAddButton onClick={createRecord} />}
</PageHeader>
);
};