From 2f048201ad1234b26c0de180b360bf6111786122 Mon Sep 17 00:00:00 2001
From: Charles Bochet <charlesBochet@users.noreply.github.com>
Date: Thu, 27 Feb 2025 10:08:47 +0100
Subject: [PATCH] Fix field empty value check for Person standard object
 (#10533)

The previous code was not correct if labelIdentifier is a FULL_NAME.
We already have an util for this

Fixes: https://github.com/twentyhq/twenty/issues/10532
---
 .../components/RecordBoardCardHeader.tsx                  | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx b/packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx
index e0fc8d6f1..450512c51 100644
--- a/packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCardHeader.tsx
@@ -17,6 +17,7 @@ import {
 } from '@/object-record/record-field/contexts/FieldContext';
 import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
 import { getFieldButtonIcon } from '@/object-record/record-field/utils/getFieldButtonIcon';
+import { isFieldValueEmpty } from '@/object-record/record-field/utils/isFieldValueEmpty';
 import { useRecordIndexContextOrThrow } from '@/object-record/record-index/contexts/RecordIndexContext';
 import { recordIndexOpenRecordInSelector } from '@/object-record/record-index/states/selectors/recordIndexOpenRecordInSelector';
 import { RecordInlineCell } from '@/object-record/record-inline-cell/components/RecordInlineCell';
@@ -99,9 +100,10 @@ export const RecordBoardCardHeader = ({
     isRecordBoardCompactModeActiveComponentState,
   );
 
-  const isIdentifierEmpty =
-    (record?.[identifierFieldDefinition.metadata.fieldName] || '').trim() ===
-    '';
+  const isIdentifierEmpty = isFieldValueEmpty({
+    fieldDefinition: identifierFieldDefinition,
+    fieldValue: record?.[identifierFieldDefinition.metadata.fieldName],
+  });
 
   const { checkIfLastUnselectAndCloseDropdown } =
     useRecordBoardSelection(recordBoardId);