From 3015f4ce312bd90b53eb7b5304129e7c5631a18c Mon Sep 17 00:00:00 2001 From: Charles Bochet Date: Thu, 2 May 2024 15:50:40 +0200 Subject: [PATCH] Fix sync metadata script (#5253) While troubleshooting self-hosting migration, we run into issues with sync-metadata script introduced by recent changes --- .vscode/launch.json | 18 ++++++++++++++++++ .../comparators/workspace-field.comparator.ts | 5 ++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 8c8d67934..2a13f9e89 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -33,6 +33,24 @@ "internalConsoleOptions": "openOnSessionStart", "console": "internalConsole", "cwd": "${workspaceFolder}/packages/twenty-server/" + }, + { + "name": "twenty-server - command debug example", + "type": "node", + "request": "launch", + "runtimeExecutable": "npx", + "runtimeVersion": "18", + "runtimeArgs": [ + "nx", + "run", + "twenty-server:command", + "my-command", + "--my-parameter value", + ], + "outputCapture": "std", + "internalConsoleOptions": "openOnSessionStart", + "console": "internalConsole", + "cwd": "${workspaceFolder}/packages/twenty-server/" } ] } \ No newline at end of file diff --git a/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts b/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts index fb64f47fa..9da521e02 100644 --- a/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts +++ b/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts @@ -23,6 +23,9 @@ const commonFieldPropertiesToIgnore = [ 'objectMetadataId', 'isActive', 'options', + 'settings', + 'joinColumn', + 'gate', ]; const fieldPropertiesToStringify = ['defaultValue'] as const; @@ -73,7 +76,7 @@ export class WorkspaceFieldComparator { standardObjectMetadata.fields, { shouldIgnoreProperty: (property, originalMetadata) => { - if (['options', 'gate'].includes(property)) { + if (commonFieldPropertiesToIgnore.includes(property)) { return true; }