test: improve utils coverage (#4230)

* test: improve utils coverage

* refactor: review - rename isDefined to isNonNullable, update tests and return statement

packages/twenty-front/src/modules/activities/hooks/useActivityConnectionUtils.ts

@@ -8,7 +8,7 @@ import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSi
 import { getEmptyPageInfo } from '@/object-record/cache/utils/getEmptyPageInfo';
 import { useMapConnectionToRecords } from '@/object-record/hooks/useMapConnectionToRecords';
 import { ObjectRecordConnection } from '@/object-record/types/ObjectRecordConnection';
-import { isDefined } from '~/utils/isDefined';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 export const useActivityConnectionUtils = () => {
   const mapConnectionToRecords = useMapConnectionToRecords();
@@ -19,7 +19,7 @@ export const useActivityConnectionUtils = () => {
       comments: ObjectRecordConnection<Comment>;
     },
   ) => {
-    if (!isDefined(activityWithConnections)) {
+    if (!isNonNullable(activityWithConnections)) {
       throw new Error('Activity with connections is not defined');
     }
 

packages/twenty-front/src/modules/activities/hooks/useActivityTargetObjectRecords.ts

@@ -7,7 +7,7 @@ import { objectMetadataItemsState } from '@/object-metadata/states/objectMetadat
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
 import { Nullable } from '~/types/Nullable';
-import { isDefined } from '~/utils/isDefined';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 export const useActivityTargetObjectRecords = ({
   activityId,
@@ -31,7 +31,7 @@ export const useActivityTargetObjectRecords = ({
     .map<Nullable<ActivityTargetWithTargetRecord>>((activityTarget) => {
       const correspondingObjectMetadataItem = objectMetadataItems.find(
         (objectMetadataItem) =>
-          isDefined(activityTarget[objectMetadataItem.nameSingular]) &&
+          isNonNullable(activityTarget[objectMetadataItem.nameSingular]) &&
           !objectMetadataItem.isSystem,
       );
 
@@ -47,7 +47,7 @@ export const useActivityTargetObjectRecords = ({
         targetObjectNameSingular: correspondingObjectMetadataItem.nameSingular,
       };
     })
-    .filter(isDefined);
+    .filter(isNonNullable);
 
   return {
     activityTargetObjectRecords,

packages/twenty-front/src/modules/activities/hooks/useAttachRelationInBothDirections.ts

@@ -6,7 +6,7 @@ import { triggerAttachRelationOptimisticEffect } from '@/apollo/optimistic-effec
 import { useObjectMetadataItems } from '@/object-metadata/hooks/useObjectMetadataItems';
 import { getObjectMetadataItemByNameSingular } from '@/object-metadata/utils/getObjectMetadataItemBySingularName';
 import { ObjectRecord } from '@/object-record/types/ObjectRecord';
-import { isDefined } from '~/utils/isDefined';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 export const useAttachRelationInBothDirections = () => {
   const { objectMetadataItems } = useObjectMetadataItems();
@@ -46,7 +46,7 @@ export const useAttachRelationInBothDirections = () => {
         (field) => field.name === fieldNameOnSourceRecord,
       );
 
-    if (!isDefined(fieldMetadataItemOnSourceRecord)) {
+    if (!isNonNullable(fieldMetadataItemOnSourceRecord)) {
       throw new Error(
         `Field ${fieldNameOnSourceRecord} not found on object ${sourceObjectNameSingular}`,
       );
@@ -57,7 +57,7 @@ export const useAttachRelationInBothDirections = () => {
       objectMetadataItems,
     });
 
-    if (!isDefined(relationDefinition)) {
+    if (!isNonNullable(relationDefinition)) {
       throw new Error(
         `Relation metadata not found for field ${fieldNameOnSourceRecord} on object ${sourceObjectNameSingular}`,
       );

packages/twenty-front/src/modules/activities/hooks/useCreateActivityInCache.ts

@@ -14,7 +14,7 @@ import { useCreateOneRecordInCache } from '@/object-record/hooks/useCreateOneRec
 import { useFindOneRecord } from '@/object-record/hooks/useFindOneRecord';
 import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
 import { WorkspaceMember } from '@/workspace-member/types/WorkspaceMember';
-import { isDefined } from '~/utils/isDefined';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 export const useCreateActivityInCache = () => {
   const { createManyRecordsInCache: createManyActivityTargetsInCache } =
@@ -71,7 +71,7 @@ export const useCreateActivityInCache = () => {
 
             return targetObject;
           })
-          .filter(isDefined);
+          .filter(isNonNullable);
 
         const activityTargetsToCreate =
           makeActivityTargetsToCreateFromTargetableObjects({

packages/twenty-front/src/modules/activities/hooks/useOpenCreateActivityDrawerForSelectedRowIds.ts

@@ -5,7 +5,7 @@ import { ActivityType } from '@/activities/types/Activity';
 import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
 import { useRecordTableStates } from '@/object-record/record-table/hooks/internal/useRecordTableStates';
 import { getSnapshotValue } from '@/ui/utilities/recoil-scope/utils/getSnapshotValue';
-import { isDefined } from '~/utils/isDefined';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 import { ActivityTargetableObject } from '../types/ActivityTargetableEntity';
 
@@ -47,7 +47,7 @@ export const useOpenCreateActivityDrawerForSelectedRowIds = (
                 targetObjectRecord,
               };
             })
-            .filter(isDefined);
+            .filter(isNonNullable);
 
         if (relatedEntities) {
           activityTargetableObjectArray =

packages/twenty-front/src/modules/activities/hooks/useUpsertActivity.ts

@@ -16,7 +16,7 @@ import { objectShowPageTargetableObjectState } from '@/activities/timeline/state
 import { Activity } from '@/activities/types/Activity';
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
-import { isDefined } from '~/utils/isDefined';
+import { isNonNullable } from '~/utils/isNonNullable';
 
 // TODO: create a generic way to have records only in cache for create mode and delete them afterwards ?
 export const useUpsertActivity = () => {
@@ -85,7 +85,7 @@ export const useUpsertActivity = () => {
         makeActivityWithConnection(activityToCreate);
 
       if (weAreOnTaskPage) {
-        if (isDefined(activityWithConnection.completedAt)) {
+        if (isNonNullable(activityWithConnection.completedAt)) {
           injectActivitiesQueries({
             activitiesFilters: currentCompletedTaskQueryVariables?.filter,
             activitiesOrderByVariables:
@@ -125,7 +125,7 @@ export const useUpsertActivity = () => {
         const injectOnlyInIdFilterForNotesQueries =
           activityWithConnection.type !== 'Note';
 
-        if (isDefined(currentCompletedTaskQueryVariables)) {
+        if (isNonNullable(currentCompletedTaskQueryVariables)) {
           injectActivitiesQueries({
             activitiesFilters: currentCompletedTaskQueryVariables?.filter,
             activitiesOrderByVariables:
@@ -137,7 +137,7 @@ export const useUpsertActivity = () => {
           });
         }
 
-        if (isDefined(currentIncompleteTaskQueryVariables)) {
+        if (isNonNullable(currentIncompleteTaskQueryVariables)) {
           injectActivitiesQueries({
             activitiesFilters:
               currentIncompleteTaskQueryVariables?.filter ?? {},
@@ -150,7 +150,7 @@ export const useUpsertActivity = () => {
           });
         }
 
-        if (isDefined(currentNotesQueryVariables)) {
+        if (isNonNullable(currentNotesQueryVariables)) {
           injectActivitiesQueries({
             activitiesFilters: currentNotesQueryVariables?.filter,
             activitiesOrderByVariables: currentNotesQueryVariables?.orderBy,