admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: improve utils coverage (#4230)

Browse Source 
* test: improve utils coverage

* refactor: review - rename isDefined to isNonNullable, update tests and return statement
This commit is contained in:
Thaïs
2024-02-29 13:03:52 -03:00
committed by GitHub
parent 6ec0e5e995
commit 30df6c10ea
85 changed files with 396 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/favorites/hooks/useFavorites.ts
View File

@ -11,7 +11,7 @@ import { useDeleteOneRecord } from '@/object-record/hooks/useDeleteOneRecord';
import { useFindManyRecords } from '@/object-record/hooks/useFindManyRecords';
import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { isDefined } from '~/utils/isDefined';
import { isNonNullable } from '~/utils/isNonNullable';
export const useFavorites = () => {
const currentWorkspaceMember = useRecoilValue(currentWorkspaceMemberState);
@ -56,7 +56,7 @@ export const useFavorites = () => {
return favorites
.map((favorite) => {
for (const relationField of favoriteRelationFieldMetadataItems) {
if (isDefined(favorite[relationField.name])) {
if (isNonNullable(favorite[relationField.name])) {
const relationObject = favorite[relationField.name];
const relationObjectNameSingular =

9
packages/twenty-front/src/modules/favorites/utils/mapFavorites.ts
View File

@ -1,11 +1,10 @@
import { getLogoUrlFromDomainName } from '~/utils';
import { assertNotNull } from '~/utils/assert';
import { isDefined } from '~/utils/isDefined';
import { isNonNullable } from '~/utils/isNonNullable';
export const mapFavorites = (favorites: any) => {
return favorites
.map((favorite: any) => {
const recordInformation = isDefined(favorite?.person)
const recordInformation = isNonNullable(favorite?.person)
? {
id: favorite.person.id,
labelIdentifier:
@ -16,7 +15,7 @@ export const mapFavorites = (favorites: any) => {
avatarType: 'rounded',
link: `/object/person/${favorite.person.id}`,
}
: isDefined(favorite?.company)
: isNonNullable(favorite?.company)
? {
id: favorite.company.id,
labelIdentifier: favorite.company.name,
@ -33,6 +32,6 @@ export const mapFavorites = (favorites: any) => {
position: favorite?.position,
};
})
.filter(assertNotNull)
.filter(isNonNullable)
.sort((a: any, b: any) => a.position - b.position);
};