admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: improve utils coverage (#4230)

Browse Source 
* test: improve utils coverage

* refactor: review - rename isDefined to isNonNullable, update tests and return statement
This commit is contained in:
Thaïs
2024-02-29 13:03:52 -03:00
committed by GitHub
parent 6ec0e5e995
commit 30df6c10ea
85 changed files with 396 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/twenty-front/src/modules/views/components/ViewFieldsVisibilityDropdownSection.tsx
View File

@ -20,7 +20,7 @@ import { MenuItem } from '@/ui/navigation/menu-item/components/MenuItem';
import { MenuItemDraggable } from '@/ui/navigation/menu-item/components/MenuItemDraggable';
import { useListenClickOutside } from '@/ui/utilities/pointer-event/hooks/useListenClickOutside';
import { groupArrayItemsBy } from '~/utils/array/groupArrayItemsBy';
import { isDefined } from '~/utils/isDefined';
import { isNonNullable } from '~/utils/isNonNullable';
type ViewFieldsVisibilityDropdownSectionProps = {
fields: Omit<ColumnDefinition<FieldMetadata>, 'size'>[];
@ -69,7 +69,7 @@ export const ViewFieldsVisibilityDropdownSection = ({
Icon: field.isVisible ? IconMinus : IconPlus,
onClick: () => onVisibilityChange(field),
},
].filter(isDefined);
].filter(isNonNullable);
return iconButtons.length ? iconButtons : undefined;
};
@ -134,7 +134,7 @@ export const ViewFieldsVisibilityDropdownSection = ({
/>
)}
</DropdownMenuItemsContainer>
{isDefined(openToolTipIndex) &&
{isNonNullable(openToolTipIndex) &&
createPortal(
<AppTooltip
anchorSelect={`.${title}-${

4
packages/twenty-front/src/modules/views/components/ViewsDropdownButton.tsx
View File

@ -20,7 +20,7 @@ import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { HotkeyScope } from '@/ui/utilities/hotkey/types/HotkeyScope';
import { VIEWS_DROPDOWN_ID } from '@/views/constants/ViewsDropdownId';
import { useViewBar } from '@/views/hooks/useViewBar';
import { assertNotNull } from '~/utils/assert';
import { isNonNullable } from '~/utils/isNonNullable';
import { useViewScopedStates } from '../hooks/internal/useViewScopedStates';
@ -161,7 +161,7 @@ export const ViewsDropdownButton = ({
handleDeleteViewButtonClick(event, view.id),
}
: null,
].filter(assertNotNull)}
].filter(isNonNullable)}
onClick={() => handleViewSelect(view.id)}
LeftIcon={IconList}
text={view.name}