admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: improve utils coverage (#4230)

Browse Source 
* test: improve utils coverage

* refactor: review - rename isDefined to isNonNullable, update tests and return statement
This commit is contained in:
Thaïs
2024-02-29 13:03:52 -03:00
committed by GitHub
parent 6ec0e5e995
commit 30df6c10ea
85 changed files with 396 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/views/hooks/internal/useFiltersFromQueryParams.ts
View File

@ -14,7 +14,7 @@ import { useGenerateFindManyRecordsQuery } from '@/object-record/hooks/useGenera
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { ViewFilter } from '@/views/types/ViewFilter';
import { ViewFilterOperand } from '@/views/types/ViewFilterOperand';
import { assertNotNull } from '~/utils/assert';
import { isNonNullable } from '~/utils/isNonNullable';
const filterQueryParamsSchema = z.object({
filter: z.record(
@ -142,7 +142,7 @@ export const useFiltersFromQueryParams = () => {
},
),
)
).filter(assertNotNull);
).filter(isNonNullable);
},
[
apolloClient,

10
packages/twenty-front/src/modules/views/hooks/useViewBar.ts
View File

@ -7,8 +7,8 @@ import { useAvailableScopeIdOrThrow } from '@/ui/utilities/recoil-scope/scopes-i
import { ViewField } from '@/views/types/ViewField';
import { ViewFilter } from '@/views/types/ViewFilter';
import { ViewSort } from '@/views/types/ViewSort';
import { assertNotNull } from '~/utils/assert';
import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
import { isNonNullable } from '~/utils/isNonNullable';
import { ViewScopeInternalContext } from '../scopes/scope-internal-context/ViewScopeInternalContext';
import { currentViewFieldsScopedFamilyState } from '../states/currentViewFieldsScopedFamilyState';
@ -116,9 +116,7 @@ export const useViewBar = (props?: UseViewProps) => {
return;
}
const queriedViewFields = viewFields
.map((viewField) => viewField)
.filter(assertNotNull);
const queriedViewFields = viewFields.filter(isNonNullable);
if (isPersistingView) {
return;
@ -173,7 +171,7 @@ export const useViewBar = (props?: UseViewProps) => {
definition: availableFilterDefinition,
};
})
.filter(assertNotNull);
.filter(isNonNullable);
if (!isDeeplyEqual(savedViewFilters, queriedViewFilters)) {
set(savedViewFiltersState, queriedViewFilters);
@ -220,7 +218,7 @@ export const useViewBar = (props?: UseViewProps) => {
definition: availableSortDefinition,
};
})
.filter(assertNotNull);
.filter(isNonNullable);
if (!isDeeplyEqual(savedViewSorts, queriedViewSorts)) {
set(savedViewSortsState, queriedViewSorts);