admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: improve utils coverage (#4230)

Browse Source 
* test: improve utils coverage

* refactor: review - rename isDefined to isNonNullable, update tests and return statement
This commit is contained in:
Thaïs
2024-02-29 13:03:52 -03:00
committed by GitHub
parent 6ec0e5e995
commit 30df6c10ea
85 changed files with 396 additions and 240 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/twenty-front/src/testing/mock-data/index.ts
View File

@ -1,7 +1,7 @@
import { isObject, isString } from '@sniptt/guards';
import { GraphQLVariables } from 'msw';
import { isDefined } from '../../utils/isDefined';
import { isNonNullable } from '../../utils/isNonNullable';
type StringFilter = {
equals?: string;
@ -133,7 +133,7 @@ export const fetchOneFromData = <DataT extends { id: string }>(
data: Array<DataT>,
id: string,
): DataT | undefined => {
if (!isDefined(id)) {
if (!isNonNullable(id)) {
throw new Error(
`id is not defined in updateOneFromData, check that you provided where.id if needed.`,
);
@ -147,7 +147,7 @@ export const updateOneFromData = <DataT extends { id: string }>(
id: string | undefined,
payload: GraphQLVariables,
): DataT | undefined => {
if (!isDefined(id)) {
if (!isNonNullable(id)) {
throw new Error(
`id is not defined in updateOneFromData, check that you provided where.id if needed.`,
);