From 33159e29b73d36c8dfbe2fe10c0352f99cac511e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?= <71827178+bosiraphael@users.noreply.github.com> Date: Thu, 28 Nov 2024 16:03:34 +0100 Subject: [PATCH] Put workflow run actions behind feature flag (#8796) Put workflow run actions behind feature flag --- .../components/RecordAgnosticActionsSetterEffect.tsx | 2 +- .../{useGlobalActions.ts => useRecordAgnosticActions.ts} | 0 .../workflow-run-actions/hooks/useWorkflowRunActions.tsx | 7 +++++++ .../action-menu/components/RecordIndexActionMenu.tsx | 5 ++++- .../action-menu/components/RecordShowActionMenu.tsx | 5 ++++- .../components/RecordShowRightDrawerActionMenu.tsx | 5 ++++- 6 files changed, 20 insertions(+), 4 deletions(-) rename packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/hooks/{useGlobalActions.ts => useRecordAgnosticActions.ts} (100%) diff --git a/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/components/RecordAgnosticActionsSetterEffect.tsx b/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/components/RecordAgnosticActionsSetterEffect.tsx index 9652fd64c..4353a9c96 100644 --- a/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/components/RecordAgnosticActionsSetterEffect.tsx +++ b/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/components/RecordAgnosticActionsSetterEffect.tsx @@ -1,4 +1,4 @@ -import { useRecordAgnosticActions } from '@/action-menu/actions/record-agnostic-actions/hooks/useGlobalActions'; +import { useRecordAgnosticActions } from '@/action-menu/actions/record-agnostic-actions/hooks/useRecordAgnosticActions'; import { useEffect } from 'react'; export const RecordAgnosticActionsSetterEffect = () => { diff --git a/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/hooks/useGlobalActions.ts b/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/hooks/useRecordAgnosticActions.ts similarity index 100% rename from packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/hooks/useGlobalActions.ts rename to packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/hooks/useRecordAgnosticActions.ts diff --git a/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/workflow-run-actions/hooks/useWorkflowRunActions.tsx b/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/workflow-run-actions/hooks/useWorkflowRunActions.tsx index 3152bf709..6933be510 100644 --- a/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/workflow-run-actions/hooks/useWorkflowRunActions.tsx +++ b/packages/twenty-front/src/modules/action-menu/actions/record-agnostic-actions/workflow-run-actions/hooks/useWorkflowRunActions.tsx @@ -7,12 +7,15 @@ import { SnackBarVariant } from '@/ui/feedback/snack-bar-manager/components/Snac import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar'; import { useAllActiveWorkflowVersions } from '@/workflow/hooks/useAllActiveWorkflowVersions'; import { useRunWorkflowVersion } from '@/workflow/hooks/useRunWorkflowVersion'; +import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled'; import { useTheme } from '@emotion/react'; import { IconSettingsAutomation } from 'twenty-ui'; import { capitalize } from '~/utils/string/capitalize'; export const useWorkflowRunActions = () => { + const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED'); + const { addActionMenuEntry, removeActionMenuEntry } = useActionMenuEntries(); const { records: activeWorkflowVersions } = useAllActiveWorkflowVersions({ @@ -26,6 +29,10 @@ export const useWorkflowRunActions = () => { const theme = useTheme(); const addWorkflowRunActions = () => { + if (!isWorkflowEnabled) { + return; + } + for (const [ index, activeWorkflowVersion, diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx index bf0780d35..a20ff64c9 100644 --- a/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx +++ b/packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx @@ -8,12 +8,15 @@ import { ActionMenuContext } from '@/action-menu/contexts/ActionMenuContext'; import { contextStoreCurrentObjectMetadataIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataIdComponentState'; import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; +import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled'; export const RecordIndexActionMenu = () => { const contextStoreCurrentObjectMetadataId = useRecoilComponentValueV2( contextStoreCurrentObjectMetadataIdComponentState, ); + const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED'); + return ( <> {contextStoreCurrentObjectMetadataId && ( @@ -28,7 +31,7 @@ export const RecordIndexActionMenu = () => { - + {isWorkflowEnabled && } )} diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx index f42814899..177892d1d 100644 --- a/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx +++ b/packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx @@ -7,6 +7,7 @@ import { contextStoreCurrentObjectMetadataIdComponentState } from '@/context-sto import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; import { ObjectRecord } from '@/object-record/types/ObjectRecord'; import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; +import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled'; import { RecordShowPageBaseHeader } from '~/pages/object-record/RecordShowPageBaseHeader'; export const RecordShowActionMenu = ({ @@ -26,6 +27,8 @@ export const RecordShowActionMenu = ({ contextStoreCurrentObjectMetadataIdComponentState, ); + const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED'); + // TODO: refactor RecordShowPageBaseHeader to use the context store return ( @@ -48,7 +51,7 @@ export const RecordShowActionMenu = ({ /> - + {isWorkflowEnabled && } )} diff --git a/packages/twenty-front/src/modules/action-menu/components/RecordShowRightDrawerActionMenu.tsx b/packages/twenty-front/src/modules/action-menu/components/RecordShowRightDrawerActionMenu.tsx index e6ccd1da4..5d335eb69 100644 --- a/packages/twenty-front/src/modules/action-menu/components/RecordShowRightDrawerActionMenu.tsx +++ b/packages/twenty-front/src/modules/action-menu/components/RecordShowRightDrawerActionMenu.tsx @@ -6,12 +6,15 @@ import { ActionMenuContext } from '@/action-menu/contexts/ActionMenuContext'; import { contextStoreCurrentObjectMetadataIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataIdComponentState'; import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; +import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled'; export const RecordShowRightDrawerActionMenu = () => { const contextStoreCurrentObjectMetadataId = useRecoilComponentValueV2( contextStoreCurrentObjectMetadataIdComponentState, ); + const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED'); + return ( <> {contextStoreCurrentObjectMetadataId && ( @@ -24,7 +27,7 @@ export const RecordShowRightDrawerActionMenu = () => { - + {isWorkflowEnabled && } )}