fix: remove usage of probability field (#5877)

- fixes #5735 --------- Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu>
2024-07-16 13:54:35 +05:30
parent c0f6f52669
commit 364caf0fdf
18 changed files with 14 additions and 64 deletions
--- a/packages/twenty-front/src/generated-metadata/graphql.ts
+++ b/packages/twenty-front/src/generated-metadata/graphql.ts
@ -333,7 +333,6 @@ export enum FieldMetadataType {
  Numeric = 'NUMERIC',
  Phone = 'PHONE',
  Position = 'POSITION',
-  Probability = 'PROBABILITY',
  Rating = 'RATING',
  RawJson = 'RAW_JSON',
  Relation = 'RELATION',
--- a/packages/twenty-front/src/generated/graphql.tsx
+++ b/packages/twenty-front/src/generated/graphql.tsx
@ -246,7 +246,6 @@ export enum FieldMetadataType {
  Numeric = 'NUMERIC',
  Phone = 'PHONE',
  Position = 'POSITION',
-  Probability = 'PROBABILITY',
  Rating = 'RATING',
  RawJson = 'RAW_JSON',
  Relation = 'RELATION',
--- a/packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemsAsFilterDefinitions.ts
+++ b/packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemsAsFilterDefinitions.ts
@ -39,11 +39,6 @@ export const formatFieldMetadataItemsAsFilterDefinitions = ({
      return acc;
    }

-    // Todo: remove once Rating fieldtype is implemented
-    if (field.name === 'probability') {
-      return acc;
-    }
-
    return [...acc, formatFieldMetadataItemAsFilterDefinition({ field })];
  }, [] as FilterDefinition[]);

--- a/packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts
@ -82,7 +82,7 @@ export const usePersistField = () => {
          isFieldBoolean(fieldDefinition) &&
          isFieldBooleanValue(valueToPersist);

-        const fieldIsProbability =
+        const fieldIsRating =
          isFieldRating(fieldDefinition) && isFieldRatingValue(valueToPersist);

        const fieldIsNumber =
@ -119,7 +119,7 @@ export const usePersistField = () => {
          fieldIsText ||
          fieldIsBoolean ||
          fieldIsEmail ||
-          fieldIsProbability ||
+          fieldIsRating ||
          fieldIsNumber ||
          fieldIsDateTime ||
          fieldIsDate ||
--- a/packages/twenty-front/src/modules/object-record/record-field/types/guards/assertFieldMetadata.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/types/guards/assertFieldMetadata.ts
@ -51,19 +51,17 @@ type AssertFieldMetadataFunction = <
                          ? FieldNumberMetadata
                          : E extends 'PHONE'
                            ? FieldPhoneMetadata
-                            : E extends 'PROBABILITY'
-                              ? FieldRatingMetadata
-                              : E extends 'RELATION'
-                                ? FieldRelationMetadata
-                                : E extends 'TEXT'
-                                  ? FieldTextMetadata
-                                  : E extends 'UUID'
-                                    ? FieldUuidMetadata
-                                    : E extends 'ADDRESS'
-                                      ? FieldAddressMetadata
-                                      : E extends 'RAW_JSON'
-                                        ? FieldRawJsonMetadata
-                                        : never,
+                            : E extends 'RELATION'
+                              ? FieldRelationMetadata
+                              : E extends 'TEXT'
+                                ? FieldTextMetadata
+                                : E extends 'UUID'
+                                  ? FieldUuidMetadata
+                                  : E extends 'ADDRESS'
+                                    ? FieldAddressMetadata
+                                    : E extends 'RAW_JSON'
+                                      ? FieldRawJsonMetadata
+                                      : never,
 >(
  fieldType: E,
  fieldTypeGuard: (
--- a/packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldTypeConfigs.ts
+++ b/packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldTypeConfigs.ts
@ -102,11 +102,6 @@ export const SETTINGS_FIELD_TYPE_CONFIGS = {
    Icon: IconPhone,
    defaultValue: '+1234-567-890',
  },
-  [FieldMetadataType.Probability]: {
-    label: 'Rating',
-    Icon: IconTwentyStar,
-    defaultValue: '3',
-  },
  [FieldMetadataType.Rating]: {
    label: 'Rating',
    Icon: IconTwentyStar,
--- a/packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
+++ b/packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
@ -161,7 +161,7 @@ export const SettingsObjectNewFieldStep2 = () => {
      // FieldMetadataType.FullName,
      FieldMetadataType.Link,
      FieldMetadataType.Numeric,
-      FieldMetadataType.Probability,
+      // FieldMetadataType.Probability,
      // FieldMetadataType.Uuid,
      // FieldMetadataType.Phone,
    ] as const