fix: remove usage of probability field (#5877)

- fixes #5735

---------

Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu>

packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemsAsFilterDefinitions.ts

@@ -39,11 +39,6 @@ export const formatFieldMetadataItemsAsFilterDefinitions = ({
       return acc;
     }
 
-    // Todo: remove once Rating fieldtype is implemented
-    if (field.name === 'probability') {
-      return acc;
-    }
-
     return [...acc, formatFieldMetadataItemAsFilterDefinition({ field })];
   }, [] as FilterDefinition[]);
 

packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts

@@ -82,7 +82,7 @@ export const usePersistField = () => {
           isFieldBoolean(fieldDefinition) &&
           isFieldBooleanValue(valueToPersist);
 
-        const fieldIsProbability =
+        const fieldIsRating =
           isFieldRating(fieldDefinition) && isFieldRatingValue(valueToPersist);
 
         const fieldIsNumber =
@@ -119,7 +119,7 @@ export const usePersistField = () => {
           fieldIsText ||
           fieldIsBoolean ||
           fieldIsEmail ||
-          fieldIsProbability ||
+          fieldIsRating ||
           fieldIsNumber ||
           fieldIsDateTime ||
           fieldIsDate ||

packages/twenty-front/src/modules/object-record/record-field/types/guards/assertFieldMetadata.ts

@@ -51,19 +51,17 @@ type AssertFieldMetadataFunction = <
                           ? FieldNumberMetadata
                           : E extends 'PHONE'
                             ? FieldPhoneMetadata
-                            : E extends 'PROBABILITY'
-                              ? FieldRatingMetadata
-                              : E extends 'RELATION'
-                                ? FieldRelationMetadata
-                                : E extends 'TEXT'
-                                  ? FieldTextMetadata
-                                  : E extends 'UUID'
-                                    ? FieldUuidMetadata
-                                    : E extends 'ADDRESS'
-                                      ? FieldAddressMetadata
-                                      : E extends 'RAW_JSON'
-                                        ? FieldRawJsonMetadata
-                                        : never,
+                            : E extends 'RELATION'
+                              ? FieldRelationMetadata
+                              : E extends 'TEXT'
+                                ? FieldTextMetadata
+                                : E extends 'UUID'
+                                  ? FieldUuidMetadata
+                                  : E extends 'ADDRESS'
+                                    ? FieldAddressMetadata
+                                    : E extends 'RAW_JSON'
+                                      ? FieldRawJsonMetadata
+                                      : never,
 >(
   fieldType: E,
   fieldTypeGuard: (

packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldTypeConfigs.ts

@@ -102,11 +102,6 @@ export const SETTINGS_FIELD_TYPE_CONFIGS = {
     Icon: IconPhone,
     defaultValue: '+1234-567-890',
   },
-  [FieldMetadataType.Probability]: {
-    label: 'Rating',
-    Icon: IconTwentyStar,
-    defaultValue: '3',
-  },
   [FieldMetadataType.Rating]: {
     label: 'Rating',
     Icon: IconTwentyStar,