fix: remove usage of probability field (#5877)

- fixes #5735

---------

Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu>

packages/twenty-front/src/generated-metadata/graphql.ts

@@ -333,7 +333,6 @@ export enum FieldMetadataType {
   Numeric = 'NUMERIC',
   Phone = 'PHONE',
   Position = 'POSITION',
-  Probability = 'PROBABILITY',
   Rating = 'RATING',
   RawJson = 'RAW_JSON',
   Relation = 'RELATION',

packages/twenty-front/src/generated/graphql.tsx

@@ -246,7 +246,6 @@ export enum FieldMetadataType {
   Numeric = 'NUMERIC',
   Phone = 'PHONE',
   Position = 'POSITION',
-  Probability = 'PROBABILITY',
   Rating = 'RATING',
   RawJson = 'RAW_JSON',
   Relation = 'RELATION',

packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemsAsFilterDefinitions.ts

@@ -39,11 +39,6 @@ export const formatFieldMetadataItemsAsFilterDefinitions = ({
       return acc;
     }
 
-    // Todo: remove once Rating fieldtype is implemented
-    if (field.name === 'probability') {
-      return acc;
-    }
-
     return [...acc, formatFieldMetadataItemAsFilterDefinition({ field })];
   }, [] as FilterDefinition[]);
 

packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts

@@ -82,7 +82,7 @@ export const usePersistField = () => {
           isFieldBoolean(fieldDefinition) &&
           isFieldBooleanValue(valueToPersist);
 
-        const fieldIsProbability =
+        const fieldIsRating =
           isFieldRating(fieldDefinition) && isFieldRatingValue(valueToPersist);
 
         const fieldIsNumber =
@@ -119,7 +119,7 @@ export const usePersistField = () => {
           fieldIsText ||
           fieldIsBoolean ||
           fieldIsEmail ||
-          fieldIsProbability ||
+          fieldIsRating ||
           fieldIsNumber ||
           fieldIsDateTime ||
           fieldIsDate ||

packages/twenty-front/src/modules/object-record/record-field/types/guards/assertFieldMetadata.ts

@@ -51,19 +51,17 @@ type AssertFieldMetadataFunction = <
                           ? FieldNumberMetadata
                           : E extends 'PHONE'
                             ? FieldPhoneMetadata
-                            : E extends 'PROBABILITY'
+                            : E extends 'RELATION'
-                              ? FieldRatingMetadata
+                              ? FieldRelationMetadata
-                              : E extends 'RELATION'
+                              : E extends 'TEXT'
-                                ? FieldRelationMetadata
+                                ? FieldTextMetadata
-                                : E extends 'TEXT'
+                                : E extends 'UUID'
-                                  ? FieldTextMetadata
+                                  ? FieldUuidMetadata
-                                  : E extends 'UUID'
+                                  : E extends 'ADDRESS'
-                                    ? FieldUuidMetadata
+                                    ? FieldAddressMetadata
-                                    : E extends 'ADDRESS'
+                                    : E extends 'RAW_JSON'
-                                      ? FieldAddressMetadata
+                                      ? FieldRawJsonMetadata
-                                      : E extends 'RAW_JSON'
+                                      : never,
-                                        ? FieldRawJsonMetadata
-                                        : never,
 >(
   fieldType: E,
   fieldTypeGuard: (

packages/twenty-front/src/modules/settings/data-model/constants/SettingsFieldTypeConfigs.ts

@@ -102,11 +102,6 @@ export const SETTINGS_FIELD_TYPE_CONFIGS = {
     Icon: IconPhone,
     defaultValue: '+1234-567-890',
   },
-  [FieldMetadataType.Probability]: {
-    label: 'Rating',
-    Icon: IconTwentyStar,
-    defaultValue: '3',
-  },
   [FieldMetadataType.Rating]: {
     label: 'Rating',
     Icon: IconTwentyStar,

packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx

@@ -161,7 +161,7 @@ export const SettingsObjectNewFieldStep2 = () => {
       // FieldMetadataType.FullName,
       FieldMetadataType.Link,
       FieldMetadataType.Numeric,
-      FieldMetadataType.Probability,
+      // FieldMetadataType.Probability,
       // FieldMetadataType.Uuid,
       // FieldMetadataType.Phone,
     ] as const

packages/twenty-server/src/engine/api/__mocks__/object-metadata-item.mock.ts

@@ -145,13 +145,6 @@ const fieldNumericMock = {
   defaultValue: null,
 };
 
-const fieldProbabilityMock = {
-  name: 'fieldProbability',
-  type: FieldMetadataType.PROBABILITY,
-  isNullable: true,
-  defaultValue: null,
-};
-
 const fieldFullNameMock = {
   name: 'fieldFullName',
   type: FieldMetadataType.FULL_NAME,
@@ -206,7 +199,6 @@ export const fields = [
   fieldBooleanMock,
   fieldNumberMock,
   fieldNumericMock,
-  fieldProbabilityMock,
   fieldLinkMock,
   fieldLinksMock,
   fieldCurrencyMock,

packages/twenty-server/src/engine/api/graphql/workspace-schema-builder/services/type-mapper.service.ts

@@ -73,7 +73,6 @@ export class TypeMapperService {
         ),
       ],
       [FieldMetadataType.NUMERIC, BigFloatScalarType],
-      [FieldMetadataType.PROBABILITY, GraphQLFloat],
       [FieldMetadataType.POSITION, PositionScalarType],
       [FieldMetadataType.RAW_JSON, RawJSONScalar],
     ]);
@@ -109,7 +108,6 @@ export class TypeMapperService {
         ),
       ],
       [FieldMetadataType.NUMERIC, BigFloatFilterType],
-      [FieldMetadataType.PROBABILITY, FloatFilterType],
       [FieldMetadataType.POSITION, FloatFilterType],
       [FieldMetadataType.RAW_JSON, RawJsonFilterType],
     ]);
@@ -130,7 +128,6 @@ export class TypeMapperService {
       [FieldMetadataType.BOOLEAN, OrderByDirectionType],
       [FieldMetadataType.NUMBER, OrderByDirectionType],
       [FieldMetadataType.NUMERIC, OrderByDirectionType],
-      [FieldMetadataType.PROBABILITY, OrderByDirectionType],
       [FieldMetadataType.RATING, OrderByDirectionType],
       [FieldMetadataType.SELECT, OrderByDirectionType],
       [FieldMetadataType.MULTI_SELECT, OrderByDirectionType],

packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/components.utils.spec.ts

@@ -55,9 +55,6 @@ describe('computeSchemaComponents', () => {
           fieldNumeric: {
             type: 'number',
           },
-          fieldProbability: {
-            type: 'number',
-          },
           fieldLink: {
             properties: {
               label: { type: 'string' },

packages/twenty-server/src/engine/core-modules/open-api/utils/components.utils.ts

@@ -35,7 +35,6 @@ const getFieldProperties = (type: FieldMetadataType): Property => {
     case FieldMetadataType.NUMBER:
       return { type: 'integer' };
     case FieldMetadataType.NUMERIC:
-    case FieldMetadataType.PROBABILITY:
     case FieldMetadataType.RATING:
     case FieldMetadataType.POSITION:
       return { type: 'number' };

packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts

@@ -31,7 +31,6 @@ export enum FieldMetadataType {
   BOOLEAN = 'BOOLEAN',
   NUMBER = 'NUMBER',
   NUMERIC = 'NUMERIC',
-  PROBABILITY = 'PROBABILITY',
   LINK = 'LINK',
   LINKS = 'LINKS',
   CURRENCY = 'CURRENCY',

packages/twenty-server/src/engine/metadata-modules/field-metadata/interfaces/field-metadata-default-value.interface.ts

@@ -35,7 +35,6 @@ type FieldMetadataDefaultValueMapping = {
   [FieldMetadataType.NUMBER]: FieldMetadataDefaultValueNumber;
   [FieldMetadataType.POSITION]: FieldMetadataDefaultValueNumber;
   [FieldMetadataType.NUMERIC]: FieldMetadataDefaultValueString;
-  [FieldMetadataType.PROBABILITY]: FieldMetadataDefaultValueNumber;
   [FieldMetadataType.LINK]: FieldMetadataDefaultValueLink;
   [FieldMetadataType.LINKS]: FieldMetadataDefaultValueLinks;
   [FieldMetadataType.CURRENCY]: FieldMetadataDefaultValueCurrency;

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/__tests__/validate-default-value-based-on-type.spec.ts

@@ -78,18 +78,6 @@ describe('validateDefaultValueForType', () => {
     ).toBe(false);
   });
 
-  it('should validate number default value for PROBABILITY type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.PROBABILITY, 0.5).isValid,
-    ).toBe(true);
-  });
-
-  it('should return false for invalid number default value for PROBABILITY type', () => {
-    expect(
-      validateDefaultValueForType(FieldMetadataType.PROBABILITY, '50%').isValid,
-    ).toBe(false);
-  });
-
   it('should validate boolean default value for BOOLEAN type', () => {
     expect(
       validateDefaultValueForType(FieldMetadataType.BOOLEAN, true).isValid,

packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/validate-default-value-for-type.util.ts

@@ -41,7 +41,6 @@ export const defaultValueValidatorsMap = {
   [FieldMetadataType.BOOLEAN]: [FieldMetadataDefaultValueBoolean],
   [FieldMetadataType.NUMBER]: [FieldMetadataDefaultValueNumber],
   [FieldMetadataType.NUMERIC]: [FieldMetadataDefaultValueString],
-  [FieldMetadataType.PROBABILITY]: [FieldMetadataDefaultValueNumber],
   [FieldMetadataType.LINK]: [FieldMetadataDefaultValueLink],
   [FieldMetadataType.CURRENCY]: [FieldMetadataDefaultValueCurrency],
   [FieldMetadataType.FULL_NAME]: [FieldMetadataDefaultValueFullName],

packages/twenty-server/src/engine/metadata-modules/workspace-migration/factories/basic-column-action.factory.ts

@@ -25,7 +25,6 @@ export type BasicFieldMetadataType =
   | FieldMetadataType.EMAIL
   | FieldMetadataType.NUMERIC
   | FieldMetadataType.NUMBER
-  | FieldMetadataType.PROBABILITY
   | FieldMetadataType.BOOLEAN
   | FieldMetadataType.POSITION
   | FieldMetadataType.DATE_TIME

packages/twenty-server/src/engine/metadata-modules/workspace-migration/utils/field-metadata-type-to-column-type.util.ts

@@ -22,7 +22,6 @@ export const fieldMetadataTypeToColumnType = <Type extends FieldMetadataType>(
     case FieldMetadataType.NUMERIC:
       return 'numeric';
     case FieldMetadataType.NUMBER:
-    case FieldMetadataType.PROBABILITY:
     case FieldMetadataType.POSITION:
       return 'float';
     case FieldMetadataType.BOOLEAN:

packages/twenty-server/src/engine/metadata-modules/workspace-migration/workspace-migration.factory.ts

@@ -72,10 +72,6 @@ export class WorkspaceMigrationFactory {
       [FieldMetadataType.NUMBER, { factory: this.basicColumnActionFactory }],
       [FieldMetadataType.POSITION, { factory: this.basicColumnActionFactory }],
       [FieldMetadataType.RAW_JSON, { factory: this.basicColumnActionFactory }],
-      [
-        FieldMetadataType.PROBABILITY,
-        { factory: this.basicColumnActionFactory },
-      ],
       [FieldMetadataType.BOOLEAN, { factory: this.basicColumnActionFactory }],
       [FieldMetadataType.DATE_TIME, { factory: this.basicColumnActionFactory }],
       [FieldMetadataType.DATE, { factory: this.basicColumnActionFactory }],