Feat/activity optimistic activities (#4009)

* Fix naming

* Fixed cache.evict bug for relation target deletion

* Fixed cascade delete activity targets

* Working version

* Fix

* fix

* WIP

* Fixed optimistic effect target inline cell

* Removed openCreateActivityDrawer v1

* Ok for timeline

* Removed console.log

* Fix update record optimistic effect

* Refactored activity queries into useActivities for everything

* Fixed bugs

* Cleaned

* Fix lint

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/activities/hooks/useUpsertActivity.ts

@@ -1,14 +1,21 @@
-import { useRecoilState } from 'recoil';
+import { useApolloClient } from '@apollo/client';
+import { useRecoilState, useRecoilValue, useSetRecoilState } from 'recoil';
 
 import { useCreateActivityInDB } from '@/activities/hooks/useCreateActivityInDB';
-import { isCreatingActivityState } from '@/activities/states/isCreatingActivityState';
+import { activityInDrawerState } from '@/activities/states/activityInDrawerState';
+import { isActivityInCreateModeState } from '@/activities/states/isActivityInCreateModeState';
+import { isUpsertingActivityInDBState } from '@/activities/states/isCreatingActivityInDBState';
+import { useInjectIntoTimelineActivitiesQueries } from '@/activities/timeline/hooks/useInjectIntoTimelineActivitiesQueries';
+import { timelineTargetableObjectState } from '@/activities/timeline/states/timelineTargetableObjectState';
 import { Activity } from '@/activities/types/Activity';
+import { useActivityConnectionUtils } from '@/activities/utils/useActivityConnectionUtils';
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
 
+// TODO: create a generic way to have records only in cache for create mode and delete them afterwards ?
 export const useUpsertActivity = () => {
-  const [isCreatingActivity, setIsCreatingActivity] = useRecoilState(
-    isCreatingActivityState,
+  const [isActivityInCreateMode, setIsActivityInCreateMode] = useRecoilState(
+    isActivityInCreateModeState,
   );
 
   const { updateOneRecord: updateOneActivity } = useUpdateOneRecord<Activity>({
@@ -17,26 +24,67 @@ export const useUpsertActivity = () => {
 
   const { createActivityInDB } = useCreateActivityInDB();
 
-  const upsertActivity = ({
+  const [, setIsUpsertingActivityInDB] = useRecoilState(
+    isUpsertingActivityInDBState,
+  );
+
+  const setActivityInDrawer = useSetRecoilState(activityInDrawerState);
+
+  const timelineTargetableObject = useRecoilValue(
+    timelineTargetableObjectState,
+  );
+
+  const { injectIntoTimelineActivitiesQueries } =
+    useInjectIntoTimelineActivitiesQueries();
+
+  const { makeActivityWithConnection } = useActivityConnectionUtils();
+
+  const apolloClient = useApolloClient();
+
+  const upsertActivity = async ({
     activity,
     input,
   }: {
     activity: Activity;
     input: Partial<Activity>;
   }) => {
-    if (isCreatingActivity) {
-      createActivityInDB({
+    setIsUpsertingActivityInDB(true);
+
+    if (isActivityInCreateMode) {
+      const activityToCreate: Activity = {
         ...activity,
         ...input,
+      };
+
+      const { activityWithConnection } =
+        makeActivityWithConnection(activityToCreate);
+
+      // Call optimistic effects
+      if (timelineTargetableObject) {
+        injectIntoTimelineActivitiesQueries({
+          timelineTargetableObject: timelineTargetableObject,
+          activityToInject: activityWithConnection,
+          activityTargetsToInject: activityToCreate.activityTargets,
+        });
+      }
+
+      await createActivityInDB(activityToCreate);
+
+      await apolloClient.refetchQueries({
+        include: ['FindManyActivities', 'FindManyActivityTargets'],
       });
 
-      setIsCreatingActivity(false);
+      setActivityInDrawer(activityToCreate);
+
+      setIsActivityInCreateMode(false);
     } else {
-      updateOneActivity?.({
+      await updateOneActivity?.({
         idToUpdate: activity.id,
         updateOneRecordInput: input,
       });
     }
+
+    setIsUpsertingActivityInDB(false);
   };
 
   return {